RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1125957 - ccs --setconf doesn't check for missing hostname
Summary: ccs --setconf doesn't check for missing hostname
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: ricci
Version: 6.6
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Chris Feist
QA Contact: cluster-qe@redhat.com
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-01 12:55 UTC by Radek Steiger
Modified: 2015-07-22 07:33 UTC (History)
1 user (show)

Fixed In Version: ccs-0.16.2-77.el6.x86_64
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-22 07:33:52 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1405 0 normal SHIPPED_LIVE ricci bug fix and enhancement update 2015-07-20 18:07:08 UTC

Description Radek Steiger 2014-08-01 12:55:29 UTC
Description of problem:

Using ccs --setconf without specifying a hostname results in a traceback:

# ccs --setconf -f /etc/cluster/cluster.conf 
Traceback (most recent call last):
  File "/usr/sbin/ccs", line 2450, in <module>
    main(sys.argv[1:])
  File "/usr/sbin/ccs", line 271, in main
    if (sendconf): send_cluster_conf()
  File "/usr/sbin/ccs", line 2217, in send_cluster_conf
    set_cluster_conf(xml, False)
  File "/usr/sbin/ccs", line 2252, in set_cluster_conf
    log_msg (send_ricci_command("cluster", "set_cluster.conf", hostname, ("cluster.conf","xml","",xml)))
  File "/usr/sbin/ccs", line 2339, in send_ricci_command
    res = send_to_ricci(msg, host)
  File "/usr/sbin/ccs", line 2362, in send_to_ricci
    (family, socktype, proto, canonname, sockaddr) = socket.getaddrinfo(host, RICCI_PORT)[0]
TypeError: getaddrinfo() argument 1 must be string or None

When only the filename is omitted however, a proper error message is printed, so this bug is most likely a missing case check:

[root@virt-102 cluster]# ccs --setconf -h localhost
Error: must specify a filename and host when using --setconf

(This bug is not related to the fix of bug 917809 as it can be reproduced with older ccs versions too.)



Version-Release number of selected component (if applicable):
ccs-0.16.2-69.el6.x86_64
ccs-0.16.2-75.el6.x86_64

How reproducible:
Always

Steps to Reproduce:
1. ccs --setconf -f /etc/cluster/cluster.conf 
2.
3.

Actual results:
Traceback (see above)

Expected results:
Error message (see above)

Comment 1 Chris Feist 2014-08-05 21:30:29 UTC
Fixed upstream with these two commits (require -h to use --setconf)

https://github.com/feist/ccs/commit/285a8a1c4c6280e2d5e7574d74caf5c6777932dd
https://github.com/feist/ccs/commit/8bea49e03ad7c834dcf1a91c380621440c9dc24f

Comment 2 Chris Feist 2015-03-03 23:24:08 UTC
Before Fix:

[root@ask-03 ~]# rpm -q ccs
ccs-0.16.2-75.el6.x86_64
[root@ask-03 ~]# ccs -f test_file  --createcluster test
[root@ask-03 ~]# ccs --setconf -f test_file
Traceback (most recent call last):
  File "/usr/sbin/ccs", line 2450, in <module>
    main(sys.argv[1:])
  File "/usr/sbin/ccs", line 271, in main
    if (sendconf): send_cluster_conf()
  File "/usr/sbin/ccs", line 2217, in send_cluster_conf
    set_cluster_conf(xml, False)
  File "/usr/sbin/ccs", line 2252, in set_cluster_conf
    log_msg (send_ricci_command("cluster", "set_cluster.conf", hostname, ("cluster.conf","xml","",xml)))
  File "/usr/sbin/ccs", line 2339, in send_ricci_command
    res = send_to_ricci(msg, host)
  File "/usr/sbin/ccs", line 2362, in send_to_ricci
    (family, socktype, proto, canonname, sockaddr) = socket.getaddrinfo(host, RICCI_PORT)[0]
TypeError: getaddrinfo() argument 1 must be string or None


After Fix:
[root@ask-02 ~]# rpm -q ccs
ccs-0.16.2-77.el6.x86_64
[root@ask-02 ~]# ccs -f test_file  --createcluster test
[root@ask-02 ~]# ccs --setconf -f test_file 
Error: you must specify a filename and host when using --setconf
[root@ask-02 ~]#

Comment 5 errata-xmlrpc 2015-07-22 07:33:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1405.html


Note You need to log in before you can comment on or make changes to this bug.