Description of problem:
Cannot use autocompletion whith fish shell
Version-Release number of selected component (if applicable):
Write `docker [TAB]` using fish shell.
Shows directories in CWD.
attach events import load pull run tag
build export info login push save top
commit help insert logs restart search version
cp history inspect port rm start wait
diff images kill ps rmi stop
Current version of Docker provides it: https://github.com/docker/docker/blob/v1.0.0/contrib/completion/fish/docker.fish
Can you test this rpm please: https://lsm5.fedorapeople.org/docker-io-1.1.2-3.fc20.x86_64.rpm
The rawhide version of this doesn't seem to work for me. I see this on fish:
source: Error while reading file “/usr/share/fish/completions/docker.fish”
(In reply to Lokesh Mandvekar from comment #1)
> Can you test this rpm please:
> The rawhide version of this doesn't seem to work for me. I see this on fish:
> source: Error while reading file “/usr/share/fish/completions/docker.fish”
The same for me.
The weird thing is that I copied https://raw.githubusercontent.com/docker/docker/v1.0.0/contrib/completion/fish/docker.fish to ~/.config/fish/completions/docker.fish and it worked fine. Well, not as fine as the bash completion, but at least it's something.
This is problematic. We don't want docker to _require_ fish, but that's what owns the /usr/share/fish/completions directory
Hmm, looks like it'd be better to have docker.fish included in upstream fish /fish rpm ?
(Same should also apply to zsh in that case (my bad))
That seems to be fish's way: https://github.com/fish-shell/fish-shell/tree/master/share/completions
Other option is to make a separate package.
Hmm, looks like docker completion is already in master https://github.com/fish-shell/fish-shell/blob/master/share/completions/docker.fish , so it should probably show up in a fish update
I'll be adding fish completion in a docker-fish subpackage.
hmm, let me test this before committing to add it :| . My guess is it would conflict with the file already installed via fish.
This has been included since 1.4.1-1 though these haven't landed in stable yet. Hopefully we'll get a stable push for 1.4.1-1 soon :|
(In reply to Lokesh Mandvekar from comment #9)
> This has been included since 1.4.1-1 though these haven't landed in stable
> yet. Hopefully we'll get a stable push for 1.4.1-1 soon :|
I'd love to test it. Could you please add the link for adding karma?
(In reply to Yajo from comment #10)
> (In reply to Lokesh Mandvekar from comment #9)
> > This has been included since 1.4.1-1 though these haven't landed in stable
> > yet. Hopefully we'll get a stable push for 1.4.1-1 soon :|
> I'd love to test it. Could you please add the link for adding karma?
assuming you've switched to f21, please test and add karma here: https://admin.fedoraproject.org/updates/FEDORA-2015-0641/docker-io-1.4.1-5.fc21
if you're still on f20, this is probably the one: https://admin.fedoraproject.org/updates/FEDORA-2015-0451/docker-io-1.4.1-4.fc20 . This version doesn't have the fix for avoiding /.docker (which is coming in a later build for f20), but it should be good RE: fish subpackage.
So, the f21 build has landed in stable. I'm closing this one.