Bug 1127808 - Review Request: perl-Test-YAML - Testing Module for YAML Implementations
Summary: Review Request: perl-Test-YAML - Testing Module for YAML Implementations
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1127647
TreeView+ depends on / blocked
 
Reported: 2014-08-07 15:22 UTC by Paul Howarth
Modified: 2014-08-08 15:21 UTC (History)
2 users (show)

Fixed In Version: perl-Test-YAML-1.01-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-08 15:21:04 UTC
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Paul Howarth 2014-08-07 15:22:35 UTC
Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Test-YAML/branches/fedora/perl-Test-YAML.spec
SRPM URL: http://www.city-fan.org/~paul/extras/perl-Test-YAML/perl-Test-YAML-1.00-2.fc22.src.rpm

Description:
Test::YAML is a subclass of Test::Base with YAML specific support.

Fedora Account System Username: pghmcfc

Comment 1 David Dick 2014-08-08 09:48:44 UTC
Ingy has already included your patch in version 1.01. Nice!

Comment 2 David Dick 2014-08-08 10:11:38 UTC
License is good.

Package builds at http://koji.fedoraproject.org/koji/taskinfo?taskID=7258107

The BuildRoot tag may be removed.

The patch may be removed (and the source updated to 1.01) as Ingy has released a new version incorporating the patch.

I don't see the source of the the version restriction on Test::More.  Is this needed?

rpmlint is completely clean.

As this package cannot build in f20 due to the Test::Base requirement, you could use the NO_PACKLIST option available in Makefile.PL in f21+.

Package APPROVED.

Comment 3 Paul Howarth 2014-08-08 12:17:58 UTC
New Package SCM Request
=======================
Package Name: perl-Test-YAML
Short Description: Testing Module for YAML Implementations
Owners: pghmcfc
Branches: f21
InitialCC: perl-sig

Test::More 0.88 is needed for done_testing in t/use_ok.t

Thanks for the review David. Hopefully I'll have time to look at yours this evening. Thanks for the NO_PACKLIST tip, I wasn't aware of that.

Comment 4 Gwyn Ciesla 2014-08-08 12:40:01 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.