Bug 1127873 - The agent's config export command produces an invalid XML file. [NEEDINFO]
Summary: The agent's config export command produces an invalid XML file.
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Agent
Version: JON 3.1.2
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ER01
: JON 3.3.0
Assignee: RHQ Project Maintainer
QA Contact: Mike Foley
URL:
Whiteboard:
Keywords: Triaged
Depends On: 782915 1038728
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-07 18:04 UTC by John Mazzitelli
Modified: 2018-12-03 21:10 UTC (History)
8 users (show)

(edit)
The JON agent's 'config export' command generated an invalid XML file due to an introduced regression in upstream code that erroneously stripped the DOCTYPE and DTD declaration from the file. The absence of a DOCTYPE and DTD results in an invalid XML file and the file subsequently failed validation by the Java Preference system when parsed. The fix corrects the introduced regression, and resolves the issue of exporting valid configuration files.
Clone Of: 1038728
(edit)
Last Closed: 2014-12-11 14:00:04 UTC
jmorgan: needinfo? (mfoley)


Attachments (Terms of Use)


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 137893 None None None Never

Comment 1 John Mazzitelli 2014-08-07 20:03:42 UTC
getting conflict when doing:

   git cherry-pick -x d6c14baa1bc2f4b8e63045abe10bf4d62878708c

need someone who knows what changed to do the cherry pick

Comment 2 Libor Zoubek 2014-08-08 10:29:54 UTC
I'll cherry-pick this one

Comment 3 Libor Zoubek 2014-08-08 10:45:18 UTC
commit c9f95872fc04c57300716fff5f9e36523747b3c8
Author: burmanm <miburman@redhat.com>
Date:   Fri Jul 11 19:00:06 2014 +0300

    [BZ 1038728] [BZ 782915] Add required DOCTYPE declaration back, but do not use it on indenting phase

    (cherry picked from commit d6c14baa1bc2f4b8e63045abe10bf4d62878708c)
    Signed-off-by: Libor Zoubek <lzoubek@redhat.com>

    Conflicts:
        modules/enterprise/agent/src/test/java/org/rhq/enterprise/agent/AgentConfigurationTest.java

Comment 4 Simeon Pinder 2014-08-19 23:50:23 UTC
Moving to ON_QA as available to test in the following brew build:

https://brewweb.devel.redhat.com//buildinfo?buildID=379025


Note You need to log in before you can comment on or make changes to this bug.