Spec URL: https://smani.fedorapeople.org/review/qhexedit2.spec SRPM URL: https://smani.fedorapeople.org/review/qhexedit2-0.6.3-1.fc22.src.rpm Description: Binary Editor for Qt Fedora Account System Username: smani
The reason I didn't put it up to the queue is that this is a dead project, maybe upstream will move to other alternatives. I hope you can understand. I can review this one, but I want to get the future development schedule of sqlb first. Thanks.
I see. I guess [1] would be an alternative, though Qt5 only. Is there somewhere where one can follow the upstream discussion? [1] https://github.com/Dax89/QHexEdit
Hi Christopher, What do you think about continuing with this regardless of the qhexedit situation? I think the sqlitemanager is a really nice tool to have, and personally I'm not overly concerned about the qhexedit project being dead (it is by far not the only one), since it seems to work just fine. If you know that upstream has plans to migrate away from it, we could also ask for a bundling exception. Thanks
This seems rather nicely packaged. * Named correctly - Not sure about version/release & the upstream source (see below) - Not sure about the license tag (see below) - License file not shipped in main package (see below) * SPEC file clean and legible * Builds fine in mock - Documentation bundles jquery (see below) * Filelist sane * Dependencies sane 0.) You seem to be packaging a SCM snapshot Please follow the release tag guidelines: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages 1.) Please pinpoint the source file to a particular SVN revision Use -r option with svn in your source comment. 2.) Why is the license tag LGPLv2+? A LGPLv2 license text is shipped, but it's unclear what it applies to. Upstream needs to clarify that license applies (preferrably in source code), whether it's LGPLv2 or LGPLv2+. 3.) Please remove copy of jquery from documentation package Use packaged version if needed. 4.) Please add license text to main package Not just the -doc subpackage.
Also you may consider making the -doc subpackage noarch.
Spec URL: https://smani.fedorapeople.org/review/qhexedit2.spec SRPM URL: https://smani.fedorapeople.org/review/qhexedit2-0.6.3-2.20141212svnr41.fc22.src.rpm %changelog * Fri Dec 12 2014 Sandro Mani <manisandro> - 0.6.3-2.20141212svnr41 - Update source file name to include svn revision - Fix license LGPLv2+ -> LGPLv2 - Added -Wl,--as-needed to fix unused-direct-shlib-dependency > 0.) You seem to be packaging a SCM snapshot > Please follow the release tag guidelines: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Done > 1.) Please pinpoint the source file to a particular SVN revision > Use -r option with svn in your source comment. Done > 2.) Why is the license tag LGPLv2+? Right, the + should not be there... > A LGPLv2 license text is shipped, but it's unclear what it applies to. Upstream needs to clarify that license applies (preferrably in source code), whether it's LGPLv2 or LGPLv2+. I think using LGPLv2 is the correct thing to do. > 3.) Please remove copy of jquery from documentation package According to http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries: Temporary exception for anything to bundle jquery. -> Added Provides: bundled(jquery) to -doc > 4.) Please add license text to main package > Not just the -doc subpackage. The main package gets it via dependency on -libs. > Also you may consider making the -doc subpackage noarch. Uhm, already is?:)
Okay. Looks fine to me now. APPROVED
Thank you! Let me know if I can review anything in exchange. New Package SCM Request ======================= Package Name: qhexedit2 Short Description: Binary Editor for Qt Owners: smani Branches: f20 f21
Git done (by process-git-requests).
qhexedit2-0.6.3-2.20141212svnr41.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/qhexedit2-0.6.3-2.20141212svnr41.fc21
qhexedit2-0.6.3-2.20141212svnr41.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/qhexedit2-0.6.3-2.20141212svnr41.fc20
qhexedit2-0.6.3-2.20141212svnr41.fc21 has been pushed to the Fedora 21 testing repository.
qhexedit2-0.6.3-2.20141212svnr41.fc20 has been pushed to the Fedora 20 stable repository.
qhexedit2-0.6.3-2.20141212svnr41.fc21 has been pushed to the Fedora 21 stable repository.