Created attachment 925504 [details]
Description of problem:
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.try to add vm from a template(not 'Blank') when not having sufficient permissions
should display an error message like : "insufficient permissions to execute this command"
I guess you attached wrong pictures...
Created attachment 925809 [details]
Oops,forgot the important one
so which permissions did you have?
i had cluster admin on a specific cluster without permissions on dc
seems you have an error somewhere…did you check the other tabs? Is the first attachment from the same attempt? If so then you have missing target SD in red. When you switch the tab it's not highlighted though
Michal,All images are from the same attempt, the problem is that when trying to add vm from template , UI does not prompt any Error.
gui remains indifferent to this command though the button is pushed clearly ( see comment #2 ).
Then,when entering the resource allocation tab, the target domain boxes are highlighted in red,but with no explanation at all.
On vm creation menu (see attachment comment #2 ) - an error message like "insufficient permissions to execute this command"
On resource allocation menu (see attachment at description) - target domain boxes
are highlighted in red(that's good) and I expect to see some kind of text that clarifies things: " you have insufficient permissions to make changes on storage domains"
(In reply to Ori from comment #6)
this is a general issue with validation in dialogs with subtabs.
@Einav, thoughts? I would say the tab should be always highlighted too. Also in my opinion the highlight is often very easy to miss, it would help when the frame is a bit more thick, or perhaps some other additional balloon popup or something
Created attachment 926544 [details]
screen-cast: marking side-section as invalid
AFAIK, the problem here is that the "resource allocation" side-section is not marked as invalid - need to fix that (we are already doing that everywhere else - see attachment 926544 [details] to see one example).
we (ux) have an RFE open for improving the code infrastructure so that the code will automatically mark a side-section as invalid in case it identifies at least one invalid field in it [instead of the developer marking that side-section as invalid manually (see bug 1123620)]; this RFE is not targeted to any foreseeable engine release, therefore if you would like to resolve the particular "resource allocation" issue soon, you would have to do that manually.
with regards to improving the highlighting nature itself: this is a separate issue; the idea is to adopt the PatternFly styling, which is completely different than what we have today (including invalid-input notification).
Ori, please check the behavior once you fill in the target SD.
Michal,please explain what do you mean by "fill in the target SD"
that's your actual error in the resource allocation subtab, the disks' target storage domain
Why is that?,the user lacks the required permissions to add the vm because this operation makes changes on the sd,the user (none admin) doesn't see the targets, that's fair enough due to lack of permissions on dc, the problem is that "creation menu" remains indifferent to the attempt of creating vm and doesn't prompt any error nor explanation
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.