Created attachment 927419 [details] image Description of problem: when setting FreeSpaceCriticalLowInGB to a number that is larger than the amount of space at the storage domain,engine blocks all actions on domains with CNA except editing actions. Version-Release number of selected component (if applicable): rc1 How reproducible: 100% Steps to Reproduce: 1.run 'engine-config -s FreeSpaceCriticalLowInGB=2147483647' 2.restart engine (service ovrit-engine restart) 3.try to create a disk,run vm,create template Actual results: almost all actions are blocked Expected results: the threshold should be correlated with domain's size Additional info:
Any number you'd want to cap it with will ultimately fail some customer with a ridiculously large storage array. We don't nanny the user.
That's why I wrote at the expected result: "the threshold should be correlated with domain's size",should be so easy to implement and when considering the enormous damage it can save,I really don't understand this decision. What are we saying here? That the fact that we have a seemingly harmless flag which most users are not even familiar with ,and can cause the entire engine to be blocked with CDA (security breach?) and we are ok with that? I say we should choose the alternative and spend five minutes to set threshold_max =< 50% domain's_size
(In reply to Ori from comment #2) > That's why I wrote at the expected result: "the threshold should be > correlated with domain's size", should be so easy to implement The point isn't the ease of implementation, it's it's (lack of) correctness. > and when > considering the enormous damage it can save, None. Exactly 0 "damage". If a user needs this kind of reliance (probably because of some underlying storage array consideration), we should allow it. We do not nanny the user. > That the fact that we have a seemingly harmless flag which most users are > not even familiar with A user who isn't familiar with a flag won't go ahead and play with it. > ,and can cause the entire engine to be blocked with > CDA (security breach?) You need access to the machine running oVirt Engine in order to do this. There's no security breach here.