REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#12) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#4) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#3) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#13) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#5) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#4) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#14) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#6) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#5) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#15) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#7) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#6) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#16) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#8) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#7) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#17) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#9) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#8) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#18) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#10) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#9) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#19) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#11) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#10) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#20) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#12) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#11) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#21) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#13) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#12) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#22) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#14) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#13) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#23) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#15) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#14) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#24) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#16) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#15) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8516 (Cluster/DHT : Additional log messages) posted (#1) for review on master by N Balachandran (nbalacha)
REVIEW: http://review.gluster.org/8453 (cluster/dht: introduce locking api.) posted (#25) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8484 (libglusterfs/syncop: implement inodelk) posted (#17) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8485 (cluster/dht: synchronize rename and file-migration) posted (#16) for review on dht-stale-layout-fixes by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8521 (cluster/dht: introduce locking api.) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8522 (libglusterfs/syncop: implement inodelk) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8523 (cluster/dht: synchronize rename and file-migration) posted (#1) for review on master by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/8516 committed in master by Vijay Bellur (vbellur) ------ commit 3f019874a4726d4b2df7c8e81581b9bed5caeb93 Author: Nithya Balachandran <nbalacha> Date: Fri Aug 22 15:16:40 2014 +0530 Cluster/DHT : Additional log messages Adding log messages in the rename and lookup calls to help with debugging. Change-Id: I13b1c6f98fb49ead45362550c46359ab1f9028c0 BUG: 1130888 Signed-off-by: Nithya Balachandran <nbalacha> Reviewed-on: http://review.gluster.org/8516 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp>
REVIEW: http://review.gluster.org/8521 (cluster/dht: introduce locking api.) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8522 (libglusterfs/syncop: implement inodelk) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8523 (cluster/dht: synchronize rename and file-migration) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8521 (cluster/dht: introduce locking api.) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8522 (libglusterfs/syncop: implement inodelk) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8523 (cluster/dht: synchronize rename and file-migration) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8521 (cluster/dht: introduce locking api.) posted (#4) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8522 (libglusterfs/syncop: implement inodelk) posted (#4) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8523 (cluster/dht: synchronize rename and file-migration) posted (#4) for review on master by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/8521 committed in master by Vijay Bellur (vbellur) ------ commit a1fe3d72e373bf0deaed152842d12d94bb9129dc Author: Raghavendra G <rgowdapp> Date: Mon Aug 11 10:14:18 2014 +0530 cluster/dht: introduce locking api. Change-Id: I41389ba91951d3e63e617aa32cd0bee848261c72 BUG: 1130888 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/8521 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/8522 committed in master by Vijay Bellur (vbellur) ------ commit 172100209e531e94168d0974bfb0995704d9dddd Author: Raghavendra G <rgowdapp> Date: Thu Aug 14 16:44:23 2014 +0530 libglusterfs/syncop: implement inodelk Change-Id: Iea489157490b70cb2bb03576b0d4943c6d8f052d BUG: 1130888 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/8522 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/8547 (dht: Avoid using inline, if necessary use it with 'static inline') posted (#1) for review on master by Harshavardhana (harsha)
REVIEW: http://review.gluster.org/8523 (cluster/dht: synchronize rename and file-migration) posted (#5) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8548 (cluster/dht: remove specifying cached-subvol as part of name in unlink.) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8549 (cluster/dht: invoke callback when there are no locks to be unlocked.) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8550 (cluster/dht: synchronize unlink and rename on an inode.) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8549 (cluster/dht: invoke callback when there are no locks to be unlocked.) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8523 (cluster/dht: synchronize rename and file-migration) posted (#6) for review on master by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/8549 committed in master by Vijay Bellur (vbellur) ------ commit a1b02e53a5fdf706290ce143fbbf8a09845105d0 Author: Raghavendra G <rgowdapp> Date: Wed Aug 27 11:27:33 2014 +0530 cluster/dht: invoke callback when there are no locks to be unlocked. Change-Id: I375cb68f1075c2d58cf9d09ed6bd5e2746e1637d BUG: 1130888 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/8549 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: N Balachandran <nbalacha> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/8523 committed in master by Vijay Bellur (vbellur) ------ commit 21c8946b0bc05d0bc8f84906e16b8c2cbca4c9f9 Author: Raghavendra G <rgowdapp> Date: Thu Aug 21 21:35:52 2014 +0530 cluster/dht: synchronize rename and file-migration Change-Id: I4f243c946f76d440680b651235f925e3d0ebf0fd BUG: 1130888 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/8523 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/8563 (cluster/dht: Treat linkto file rename failure as non-critial error) posted (#1) for review on master by Raghavendra G (rgowdapp)
COMMIT: http://review.gluster.org/8547 committed in master by Harshavardhana (harsha) ------ commit 04be6a47df5c7d5c04c84fed06df9a8a1652c582 Author: Harshavardhana <harsha> Date: Tue Aug 26 14:57:42 2014 -0700 dht: Avoid using inline, if necessary use it with 'static inline' This avoids flat namespace problems on OSX and with clang Change-Id: Id80d94d71b120c6b1166218caa8cf9cf7f2da03a BUG: 1130888 Signed-off-by: Harshavardhana <harsha> Reviewed-on: http://review.gluster.org/8547 Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/8563 (cluster/dht: Treat linkto file rename failure as non-critial error) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8569 (USS: initialize a list before using it.) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8570 (cluster/dht: Rename should not fail post hardlink creation) posted (#1) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8563 (cluster/dht: Treat linkto file rename failure as non-critial error) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8570 (cluster/dht: Rename should not fail post hardlink creation) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8569 (USS: initialize a list before using it.) posted (#2) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8563 (cluster/dht: Treat linkto file rename failure as non-critial error) posted (#4) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8570 (cluster/dht: Rename should not fail post hardlink creation) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8569 (USS: initialize a list before using it.) posted (#3) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8563 (cluster/dht: Treat linkto file rename failure as non-critial error) posted (#5) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8570 (cluster/dht: Rename should not fail post hardlink creation) posted (#4) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8569 (USS: initialize a list before using it.) posted (#4) for review on master by Raghavendra G (rgowdapp)
REVIEW: http://review.gluster.org/8563 (cluster/dht: Treat linkto file rename failure as non-critial error) posted (#6) for review on master by Shyamsundar Ranganathan (srangana)
REVIEW: http://review.gluster.org/8570 (cluster/dht: Rename should not fail post hardlink creation) posted (#5) for review on master by Shyamsundar Ranganathan (srangana)
COMMIT: http://review.gluster.org/8569 committed in master by Vijay Bellur (vbellur) ------ commit 2b7a2d2c21e2329828c27e6f9556ea8d9d512021 Author: Raghavendra G <rgowdapp> Date: Sat Aug 30 16:33:59 2014 +0530 USS: initialize a list before using it. Change-Id: Iba35e4397646a67384e878fbe7bdfb7586fc07f9 BUG: 1130888 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/8569 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/8563 committed in master by Vijay Bellur (vbellur) ------ commit 890ab583a519b3b189a61c5fd563b4326836b988 Author: Shyam <srangana> Date: Wed Aug 27 15:27:46 2014 -0400 cluster/dht: Treat linkto file rename failure as non-critial error It is a critical failure iff we fail to rename the cached file if the rename of the linkto failed, it is not a critical failure, and we do not want to lose the created hard link for the new name as that could have been read by other clients. NOTE: If another client is attempting the same oldname -> newname rename, and finds both file names as existing, and are hard links to each other, then FUSE would send in an unlink for oldname. In this time duration if we treat the linkto as a critical error and unlink the newname we created, we would have effectively lost the file to rename operations. Repercussions of treating this as a non-critical error is that we could leave behind a stale linkto file and/or not create the new linkto file, the second case would be rectified by a subsequent lookup, the first case by a rebalance, like for all stale linkto files Change-Id: Ia53ad8b43c3cf8f48ef5b43fd1fec4274e807556 BUG: 1130888 Signed-off-by: Shyam <srangana> Reviewed-on: http://review.gluster.org/8563 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/8570 committed in master by Vijay Bellur (vbellur) ------ commit 4ce3db8e508e715a43352b082e861fd0e729951f Author: Shyam <srangana> Date: Fri Aug 29 15:20:40 2014 -0400 cluster/dht: Rename should not fail post hardlink creation In the rename path, we wind the creation of newname hardlink and linkto file in dst hashed a the same time. If the linkto creation fails, but the link creation succeeds, we enter the failure code and cleanup the created newname hardlink. In the interim if another client looks up newname and finds it as a hardlink from FUSE, it could send an unlink for oldname instead of a rename. This combined with the above cleanup code could end up losing all the files copies, and thereby losing data. This fix separates these steps into 2 parts, creating the linkto first and then the link file, so that post link file creation no failures would cleanup the newname file. If linkto fails then link is not attempted, thereby not polluting the name space with newname. Change-Id: I61da8e906060da16a31ea1076eec2f01fd617f44 BUG: 1130888 Signed-off-by: Shyam <srangana> Reviewed-on: http://review.gluster.org/8570 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Jeff Darcy <jdarcy> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/8548 committed in master by Vijay Bellur (vbellur) ------ commit a12cf2dedb98b115812163361846b02f8adc8353 Author: Raghavendra G <rgowdapp> Date: Wed Aug 27 10:47:24 2014 +0530 cluster/dht: remove specifying cached-subvol as part of name in unlink. commit 667b2496c3f29e24ed359a05b0f44df0d1894969 introduced a functionality where we can specify the subvol where file is stored. As part of same commit, dht_unlink was also changed to accept cached-subvol as part of name. While it makes sense to specify subvol while creating file, there is no necessity for specifying the subvol during unlink, since the default unlink logic works fine with this functionality too. Also, this code in unlink doesn't work well when files get migrated by rebalance process. Hence removing it. Change-Id: Ic3fc32ad657e2dcd677a4c80b04a618029eddd89 BUG: 1130888 Signed-off-by: Raghavendra G <rgowdapp> Reviewed-on: http://review.gluster.org/8548 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Shyamsundar Ranganathan <srangana> Reviewed-by: Jeff Darcy <jdarcy> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/8582 (Cluster/DHT: Changing rename log severity) posted (#1) for review on master by N Balachandran (nbalacha)
COMMIT: http://review.gluster.org/8582 committed in master by Vijay Bellur (vbellur) ------ commit c087e5f634a0b2262118d61ab9c1d5c8e18c8819 Author: Nithya Balachandran <nbalacha> Date: Wed Sep 3 10:42:47 2014 +0530 Cluster/DHT: Changing rename log severity Changing log level for a rename message from debug to info to improve debuggability Change-Id: I53031fcf97fffd62095692477330ecde0cf47dcd BUG: 1130888 Signed-off-by: Nithya Balachandran <nbalacha> Reviewed-on: http://review.gluster.org/8582 Reviewed-by: Vijay Bellur <vbellur> Tested-by: Gluster Build System <jenkins.com>
REVIEW: http://review.gluster.org/8601 (syncop: Invoke dict_unref() in inodelk only if dictionary is not NULL) posted (#1) for review on master by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/8601 (syncop: Invoke dict_unref() in inodelk only if dictionary is not NULL) posted (#2) for review on master by Vijay Bellur (vbellur)
COMMIT: http://review.gluster.org/8601 committed in master by Vijay Bellur (vbellur) ------ commit 331e9e2051addfcc394c933a85046f450961e1af Author: Vijay Bellur <vbellur> Date: Thu Sep 4 23:58:18 2014 +0530 syncop: Invoke dict_unref() in inodelk only if dictionary is not NULL In the absence of this check, logs can get flooded with messages like this when rebalance is run: [2014-09-04 17:48:07.148262] W [dict.c:480:dict_unref] (-->/lib64/libc.so.6() [0x30daa47a00] (-->/usr/local/lib/libglusterfs.so.0(synctask_wrap+0x12) [0x7fa20b7c6ec2] (-->/usr/local/lib/glusterfs/3.7dev/xlator/cluster/distribute.so(dht_migrate_file+0x23f) [0x7fa200fdb58f]))) 0-dict: dict is NULL Change-Id: I4c93e4485293b35d86ba07df4d583d2758ec3f49 BUG: 1130888 Signed-off-by: Vijay Bellur <vbellur> Reviewed-on: http://review.gluster.org/8601 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Shyamsundar Ranganathan <srangana>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user