Bug 1131364

+++ This bug was initially created as a clone of Bug #1130445 +++

Description of problem:
engine-setup checks for updates and asks if one wants to apply them is found.
But if one chooses not to apply it gives an error.

Version-Release number of selected component (if applicable):
ovirt-engine-setup-base-3.6.0-0.0.master.20140811142054.gite3c9ec4.el6.noarch

How reproducible:
always

Steps to Reproduce:
1. run engine-setup when some updates are available
2. installer gives output:
[ INFO  ] Checking for product updates...
          Setup has found updates for some packages, do you wish to update them now? (Yes, No) [Yes]: 

3. Answer No
installer aborts
[ ERROR ] Failed to execute stage 'Environment customization': Aborted, packages must be updated
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20140815104326-tsbpe6.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20140815104359-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of setup failed


Actual results:
setup aborts

Expected results:
setup able to continue after choosing "No"

Additional info:
If we require as mandatory to apply updates, the prompt shoulb be different form the current one.

Something like

[ INFO  ] Checking for product updates...
          Setup has found updates for some packages and requires to apply them before proceeding, do you wish to update them now and go ahead? (Yes, No) [Yes]: No
[ INFO  ] Stage: User aborted
...
[ INFO  ] Stage: Clean up

This seems to happen both if engine-setup itself needs update or some other packages only.

In case of updates for engine-setup and answer is "Yes" you get:
[ INFO  ] Checking for product updates...
          Setup has found updates for some packages, do you wish to update them now? (Yes, No) [Yes]: 
[ INFO  ] Checking for an update for Setup...
          An update for the Setup packages ovirt-engine-setup was found. Please update that package by running:
          "yum update ovirt-engine-setup"
          and then execute Setup again.
[ ERROR ] Failed to execute stage 'Environment customization': Please update the Setup packages
[ INFO  ] Stage: Clean up
          Log file is located at /var/log/ovirt-engine/setup/ovirt-engine-setup-20140815105538-7zsbx8.log
[ INFO  ] Generating answer file '/var/lib/ovirt-engine/setup/answers/20140815105756-setup.conf'
[ INFO  ] Stage: Pre-termination
[ INFO  ] Stage: Termination
[ ERROR ] Execution of setup failed

I think this is suboptimal too...

A better workflow would be in my opinion:
1a) check if updates for engine-setup exists and in case directly aborts because he/she needs to update it before 
(if this is the desired behaviour as it seems to me from the current workflow; not sure if it is correct... one could desire to rerun engine-setup again without any update at all...)

1b) if no update is available for engine-setup itself, check if there are any updates for other engine related packages and in case ask the user if he/she wants to update them before proceeding and in case of negative answer, go ahead without giving any error

--- Additional comment from Gianluca Cecchi on 2014-08-15 05:04:12 EDT ---

This was don on CentOS 6.5 system.
I'm going to attach engine-setup logs

--- Additional comment from Gianluca Cecchi on 2014-08-15 05:05:24 EDT ---



--- Additional comment from Gianluca Cecchi on 2014-08-15 05:06:10 EDT ---



--- Additional comment from Gianluca Cecchi on 2014-08-15 05:07:49 EDT ---



--- Additional comment from Gianluca Cecchi on 2014-08-15 05:11:41 EDT ---

Please note that in case there are updates available but not fr engine-setup itself and one chooses to apply them, the setup phase completes ok.
So this bug entry is related to workflow when one doesn't wants to apply updates but wnats to run engine-setup with the currently installed environment.
The problem exists both if it is the first time and when the engine as already installed before.