Bug 1131543 - Review Request: python-flask-xml-rpc - Adds support for creating XML-RPC APIs to Flask
Summary: Review Request: python-flask-xml-rpc - Adds support for creating XML-RPC APIs...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-19 14:26 UTC by Pierre-YvesChibon
Modified: 2014-08-22 17:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-08-22 17:19:49 UTC
Type: ---
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Pierre-YvesChibon 2014-08-19 14:26:26 UTC
Spec URL: http://pingou.fedorapeople.org/RPMs//python-Flask-XML-RPC.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs//python-flask-xml-rpc-0.1.2-1.fc20.src.rpm

Description:
Flask-XML-RPC adds XML-RPC support to Flask.
This way, you can provide simple APIs easily accessible from almost any
programming language.


documentation:
  http://packages.python.org/Flask-XML-RPC
development version:
  http://bitbucket.org/leafstorm/flask-xml-rpc/get/tip.gz#egg=Flask-XML-RPC-dev

Comment 1 Pierre-YvesChibon 2014-08-19 14:26:30 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=7427397

Comment 2 Parag AN(पराग) 2014-08-20 16:15:23 UTC
any plan to provide python3 subpackage?

Comment 3 Pierre-YvesChibon 2014-08-20 18:05:13 UTC
If there is one I'd loved to, but I'm not sure the code is compatible

Comment 4 Parag AN(पराग) 2014-08-21 11:04:58 UTC
Review:
+ mock build is successful for f22.

- rpmlint output on rpms gave
python-flask-xml-rpc.src: E: invalid-spec-name
2 packages and 0 specfiles checked; 1 errors, 0 warnings.

=> python-Flask-XML-RPC.spec should be python-flask-xml-rpc.spec
  See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

+ Source verified with upstream as (sha256sum)
srpm tarball     :4adc7482240a916e8c2205cba38b4bd6e648692d189419686a3116768fa48ab7
upstream tarball :4adc7482240a916e8c2205cba38b4bd6e648692d189419686a3116768fa48ab7

+ License "MIT" is valid

- License text is not included in package

=>  see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text which suggests MIT license package needs license text also. Ask upstream to provide license text

- Package must own all directories that it creates.
 
=> Directory /usr/lib/python2.7/site-packages/flaskext not owned

+ rest looks following packaging guidelines.

Comment 5 Pierre-YvesChibon 2014-08-21 11:21:42 UTC
> => python-Flask-XML-RPC.spec should be python-flask-xml-rpc.spec
>  See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

Adjusted.

> - License text is not included in package
> =>  see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
> which suggests MIT license package needs license text also.
> Ask upstream to provide license text

This has been done already: https://bitbucket.org/leafstorm/flask-xml-rpc/pull-request/1/
(Thus the commented LICENSE in the %files section)

> => Directory /usr/lib/python2.7/site-packages/flaskext not owned

That one is used by every flask extension.
Adjusted.

Spec URL: http://pingou.fedorapeople.org/RPMs//python-Flask-XML-RPC.spec
SRPM URL: http://pingou.fedorapeople.org/RPMs//python-flask-xml-rpc-0.1.2-2.fc20.src.rpm

Comment 6 Parag AN(पराग) 2014-08-21 11:44:54 UTC
I wonder why no package or python-flask not owning /usr/lib/python2.7/site-packages/flaskext. Maybe that can be worked on later on.

I also assume above spec link is wrongly pasted.

APPROVED above srpm.

Comment 7 Pierre-YvesChibon 2014-08-21 15:05:35 UTC
Sorry yes, wrong copy paste, the latest one is at: https://pingou.fedorapeople.org/RPMs//python-flask-xml-rpc.spec

Comment 8 Pierre-YvesChibon 2014-08-21 15:31:16 UTC
New Package SCM Request
=======================
Package Name: python-flask-xml-rpc
Short Description: Adds support for creating XML-RPC APIs to Flask
Upstream URL: http://pypi.python.org/pypi/Flask-XML-RPC
Owners: pingou
Branches: master, f21, epel7
InitialCC: group::fedora-infra

Comment 9 Pierre-YvesChibon 2014-08-21 15:34:09 UTC
Wrong group

New Package SCM Request
=======================
Package Name: python-flask-xml-rpc
Short Description: Adds support for creating XML-RPC APIs to Flask
Upstream URL: http://pypi.python.org/pypi/Flask-XML-RPC
Owners: pingou
Branches: master, f21, epel7
InitialCC: group::infra-sig

Comment 10 Parag AN(पराग) 2014-08-21 17:52:48 UTC
Pierre,
   we don't specify master or devel branch its created automatically. Also, If I am not wrong then we still use directly group name in InitialCC and not write group with prefix as "group::".

Comment 11 Parag AN(पराग) 2014-08-21 17:53:54 UTC
and you forgot to raise fedora-cvs? flag.

Comment 12 Pierre-YvesChibon 2014-08-21 21:01:12 UTC
Thanks for the flag, but regarding group:: it's a shiny new things from pkgdb2 (in testing), I'm curious to see how the script processing the requests handles it.

Comment 13 Gwyn Ciesla 2014-08-22 12:23:04 UTC
Git done (by process-git-requests).

See if the group::thing works.  It warned me that it's not a valid fas
account, so if it does work we'll need to patch the script to account for
that.

Comment 14 Pierre-YvesChibon 2014-08-22 12:32:06 UTC
group::infra-sig got the watch* acls just fine on pkgdb2 it looks like:
https://admin.fedoraproject.org/pkgdb/package/python-flask-xml-rpc/

I'll import the srpm and see if the mailing list gets the notification

Comment 15 Pierre-YvesChibon 2014-08-22 17:19:16 UTC
And the list does get the notifications, cool! :)


Note You need to log in before you can comment on or make changes to this bug.