Bug 1131616 - Review Request: python-copr - Python client to access copr service
Summary: Review Request: python-copr - Python client to access copr service
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Miroslav Suchý
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2014-08-19 16:39 UTC by Valentin Gologuzov
Modified: 2015-12-01 06:04 UTC (History)
3 users (show)

Fixed In Version: python-copr-1.50-1.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-09-09 22:11:20 UTC
Type: ---
msuchy: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Valentin Gologuzov 2014-08-19 16:39:18 UTC
Spec URL: https://fedorapeople.org/~vgologuz/python-copr-client.spec
SRPM URL: https://fedorapeople.org/~vgologuz/python-copr-client-1.43-1.git.0.a273806.fc20.src.rpm
COPR is lightweight build system. It allows you to create new project in WebUI,
and submit new builds and COPR will create yum repository from latests builds.
This package contains python client for access to copr service through api.
Fedora Account System Username: vgologuz

It is my first package in fedoraproject.
For some strange reasons koji can't fetch srpm, here is successfull built by copr: http://copr.fedoraproject.org/coprs/vgologuz/copr/build/28318/

Comment 1 Miroslav Suchý 2014-08-20 08:00:00 UTC

Comment 2 Miroslav Suchý 2014-08-21 13:55:24 UTC
The name python-copr-client is confusing. This is simple interaction with Copr using its API and can do many thing. I would suggest to rename it to:

#rm -rf %{buildroot}
Why to leave there commented code? Just remove it.

Also for review please submit SRPM with simple release. I.e. do not create package with 'tito --test'.

Comment 3 Valentin Gologuzov 2014-08-21 15:11:07 UTC
SPEC: http://people.redhat.com/~vgologuz/python_copr/python-copr.spec
SRPM: http://people.redhat.com/~vgologuz/python_copr/python-copr-1.45-1.fc20.src.rpm

>>> The name python-copr-client is confusing.

>>> Why to leave there commented code? Just remove it.
Cleaned it.

>>> I.e. do not create package with 'tito --test'.
Ok, built from actual tag.

Comment 4 Miroslav Suchý 2014-08-21 20:27:15 UTC
You are missing:
 %files -n python3-copr-client
section. I.e. that subpackage is not created, because it does not have files section and those python3 files go into main package.

 %if 0%{?with_python3}
 Requires: python3-six
 Requires: python3-requests
 %endif # if with_python3
should go after
 %package -n python3-copr-client
because that is requires of python3-copr-client

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc/python-copr

put into files section either
 %dir %{_pkgdocdir}/
 %doc %{_pkgdocdir}/python-doc
replace by simple
 %doc %{_pkgdocdir}

Comment 5 Miroslav Suchý 2014-08-21 20:37:35 UTC
Summary:    Code documentation for python-copr package.
Should not end with dot.

python-copr.noarch: E: description-line-too-long C This package contains python interface to access Copr service. Mostly useful for developers
python-copr-doc.noarch: E: description-line-too-long C This package includes documentation for python-copr. Mostly useful for developers
python-copr.src: E: description-line-too-long C This package contains python interface to access Copr service. Mostly useful for developers

Should be wrapped to 80 chars.


Comment 6 Valentin Gologuzov 2014-08-22 08:42:36 UTC
SPEC: http://people.redhat.com/~vgologuz/python_copr/python-copr.spec
SRPM: http://people.redhat.com/~vgologuz/python_copr/python-copr-1.46-1.fc20.src.rpm

Now creates python3-copr.
Fixed %doc to include /usr/share/doc/python-copr.
Fixed summary/description.

Also replaced $RPM_OPT_FLAGS with %{optflags}.

Comment 7 Miroslav Suchý 2014-08-25 13:30:21 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     licensecheck in /home/msuchy/1131616-python-copr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.


Comment 8 Valentin Gologuzov 2014-08-25 14:23:46 UTC
New Package SCM Request
Package Name: python-copr 
Short Description: Python interface for Copr
Upstream URL: https://git.fedorahosted.org/cgit/copr.git/ 
Owners: msuchy vgologuz
Branches: f19 f20

Comment 9 Gwyn Ciesla 2014-08-26 12:15:39 UTC
Git done (by process-git-requests).

Added f21.

Comment 10 Fedora Update System 2014-08-26 14:32:12 UTC
python-copr-1.46-1.fc20 has been submitted as an update for Fedora 20.

Comment 11 Fedora Update System 2014-08-26 15:51:50 UTC
python-copr-1.46-1.fc19 has been submitted as an update for Fedora 19.

Comment 12 Valentin Gologuzov 2014-08-26 15:55:27 UTC
Package Change Request
Package Name: python-copr 
New Branches: el6 epel7
Owners: msuchy vgologuz

Comment 13 Gwyn Ciesla 2014-08-26 16:54:16 UTC
Git done (by process-git-requests).

Comment 14 Michael Schwendt 2014-08-26 17:49:54 UTC
Kindly pay attention to the bottom of:

Comment 15 Fedora Update System 2014-08-27 01:34:31 UTC
python-copr-1.46-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 16 Fedora Update System 2014-09-08 11:45:41 UTC
python-copr-1.50-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 17 Fedora Update System 2014-09-08 11:50:24 UTC
python-copr-1.50-1.fc21 has been submitted as an update for Fedora 21.

Comment 18 Fedora Update System 2014-09-09 22:11:20 UTC
python-copr-1.46-1.fc19 has been pushed to the Fedora 19 stable repository.

Comment 19 Fedora Update System 2014-09-09 22:13:37 UTC
python-copr-1.46-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 20 Fedora Update System 2014-09-23 04:21:57 UTC
python-copr-1.50-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 21 Fedora Update System 2014-11-20 12:17:53 UTC
python-copr-1.55-1.el6 has been submitted as an update for Fedora EPEL 6.

Comment 22 Fedora Update System 2014-12-12 23:08:53 UTC
python-copr-1.55-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.