Spec URL: https://jplesnik.fedorapeople.org/perl-Module-Build-Deprecated/perl-Module-Build-Deprecated.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Module-Build-Deprecated/perl-Module-Build-Deprecated-0.4210-1.fc22.src.rpm Description: This module contains a number of module that have been removed from Module-Build: Module::Build::ModuleInfo - This has been superceded by Module::Metadata Module::Build::Version - This has been replaced by version Module::Build::YAML - This has been replaced by CPAN::Meta::YAML Fedora Account System Username: jplesnik
URL and Source0 are usable. Ok. Source archive is original (SHA-256:be089313fc238ee2183473aca8c86b55fb3cf44797312cbe9b892d6362621703). Ok. License verified from README, LICENSE, lib/Module/Build/Deprecated.pm, lib/Module/Build/YAML.pm, lib/Module/Build/Version.pm, lib/Module/Build/ModuleInfo.pm. Ok. No XS code, noarch BuildArch is Ok. Summary verified from README. Ok. Description verified from lib/Module/Build/Deprecated.pm. OK. TODO: Fix the misspelled `superceded'. TODO: Constrain `perl(Module::Build)' build-time dependency with `>= 0.3601' Pod::Coverage::TrustPod is not used. Ok. Test::Pod 1.41 is not used. Ok. Test::Pod::Coverage 1.08 is not used. Ok. All tests pass. Ok. rpmlint perl-Module-Build-Deprecated.spec ../SRPMS/perl-Module-Build-Deprecated-0.4210-1.fc22.src.rpm ../RPMS/noarch/perl-Module-Build-Deprecated-0.4210-1.fc22.noarch.rpm perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US ModuleInfo -> Module Info, Module-info, Modulation perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US superceded -> superseded, super ceded, super-ceded perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US Metadata -> Meta data, Meta-data, Metatarsal perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US ModuleInfo -> Module Info, Module-info, Modulation perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US superceded -> superseded, super ceded, super-ceded perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US Metadata -> Meta data, Meta-data, Metatarsal 2 packages and 1 specfiles checked; 0 errors, 6 warnings. TODO: Fix the misspelled `superceded'. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-Build-Deprecated-0.4210-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Aug 20 10:50 /usr/share/doc/perl-Module-Build-Deprecated -rw-r--r-- 1 root root 636 Aug 19 20:33 /usr/share/doc/perl-Module-Build-Deprecated/Changes -rw-r--r-- 1 root root 18358 Aug 19 20:33 /usr/share/doc/perl-Module-Build-Deprecated/LICENSE -rw-r--r-- 1 root root 401 Aug 19 20:33 /usr/share/doc/perl-Module-Build-Deprecated/README -rw-r--r-- 1 root root 2139 Aug 20 10:50 /usr/share/man/man3/Module::Build::Deprecated.3pm.gz -rw-r--r-- 1 root root 2130 Aug 20 10:50 /usr/share/man/man3/Module::Build::ModuleInfo.3pm.gz -rw-r--r-- 1 root root 2081 Aug 20 10:50 /usr/share/man/man3/Module::Build::Version.3pm.gz -rw-r--r-- 1 root root 2125 Aug 20 10:50 /usr/share/man/man3/Module::Build::YAML.3pm.gz drwxr-xr-x 2 root root 0 Aug 20 10:50 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 Aug 20 10:50 /usr/share/perl5/vendor_perl/Module/Build -rw-r--r-- 1 root root 985 Aug 20 10:50 /usr/share/perl5/vendor_perl/Module/Build/Deprecated.pm -rw-r--r-- 1 root root 908 Aug 20 10:50 /usr/share/perl5/vendor_perl/Module/Build/ModuleInfo.pm -rw-r--r-- 1 root root 650 Aug 20 10:50 /usr/share/perl5/vendor_perl/Module/Build/Version.pm -rw-r--r-- 1 root root 741 Aug 20 10:50 /usr/share/perl5/vendor_perl/Module/Build/YAML.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-Build-Deprecated-0.4210-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(base) 1 perl(CPAN::Meta::YAML) >= 0.002 1 perl(Module::Metadata) 1 perl(parent) 1 perl(strict) 1 perl(version) >= 0.87 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Binary requires are Ok. FIX: This package provides the same files as perl-Module-Build < 0.42.07. You have to declare appropriate `Conflicts:' tag. $ rpm -q --provides -p ../RPMS/noarch/perl-Module-Build-Deprecated-0.4210-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Module::Build::Deprecated) = 0.4210 1 perl(Module::Build::ModuleInfo) = 0.4210 1 perl(Module::Build::Version) = 0.87 1 perl(Module::Build::YAML) = 1.41 1 perl-Module-Build-Deprecated = 0.4210-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Module-Data-0.007-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7429937). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide a new spec file. Resolution: Package NOT approved.
Updated files on the same links.
Spec file changes: $ diff -u perl-Module-Build-Deprecated.spec{.old,} --- perl-Module-Build-Deprecated.spec.old 2014-08-20 09:32:07.000000000 +0200 +++ perl-Module-Build-Deprecated.spec 2014-08-20 12:10:08.000000000 +0200 @@ -13,7 +13,7 @@ BuildRequires: perl(File::Spec) BuildRequires: perl(IO::Handle) BuildRequires: perl(IPC::Open3) -BuildRequires: perl(Module::Build) +BuildRequires: perl(Module::Build) >= 0.3601 BuildRequires: perl(Module::Metadata) BuildRequires: perl(parent) BuildRequires: perl(strict) @@ -23,13 +23,14 @@ Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Requires: perl(CPAN::Meta::YAML) >= 0.002 Requires: perl(version) >= 0.87 +Conflicts: perl-Module-Build < 0.42.07 %global __requires_exclude %{?__requires_exclude|%__requires_exclude|}perl\\(CPAN::Meta::YAML|version\\) %description This module contains a number of module that have been removed from Module-Build: -Module::Build::ModuleInfo - This has been superceded by Module::Metadata +Module::Build::ModuleInfo - This has been superseded by Module::Metadata Module::Build::Version - This has been replaced by version Module::Build::YAML - This has been replaced by CPAN::Meta::YAML > TODO: Fix the misspelled `superceded'. %description This module contains a number of module that have been removed from Module-Build: -Module::Build::ModuleInfo - This has been superceded by Module::Metadata +Module::Build::ModuleInfo - This has been superseded by Module::Metadata Module::Build::Version - This has been replaced by version Module::Build::YAML - This has been replaced by CPAN::Meta::YAML Ok. > TODO: Constrain `perl(Module::Build)' build-time dependency with `>= 0.3601' -BuildRequires: perl(Module::Build) +BuildRequires: perl(Module::Build) >= 0.3601 Ok. > FIX: This package provides the same files as perl-Module-Build < 0.42.07. > You have to declare appropriate `Conflicts:' tag. +Conflicts: perl-Module-Build < 0.42.07 Ok. $ rpmlint perl-Module-Build-Deprecated.spec ../SRPMS/perl-Module-Build-Deprecated-0.4210-1.fc22.src.rpm ../RPMS/noarch/perl-Module-Build-Deprecated-0.4210-1.fc22.noarch.rpm perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US ModuleInfo -> Module Info, Module-info, Modulation perl-Module-Build-Deprecated.src: W: spelling-error %description -l en_US Metadata -> Meta data, Meta-data, Metatarsal perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US ModuleInfo -> Module Info, Module-info, Modulation perl-Module-Build-Deprecated.noarch: W: spelling-error %description -l en_US Metadata -> Meta data, Meta-data, Metatarsal 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7430245). Ok. Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Module-Build-Deprecated Short Description: Collection of modules removed from Module-Build Upstream URL: http://search.cpan.org/dist/Module-Build-Deprecated/ Owners: jplesnik ppisar psabata Branches: InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.