the ioprocess implementation introduced a log line in /var/log/messages. (just restart vdsm We shouldn't do that, everything should go to the vdsm.log I think we shouldn't log this particular information at all
There two issues here: 1. Logging unwanted messages to syslog 2. Logging unwanted messages to vdsm log The suggested patch fixes only the first issue. We need to fix both issues.
This bug has two patches, only one of them is merged: - http://gerrit.ovirt.org/31908 - merged - http://gerrit.ovirt.org/32194 - new (there is a debate on the solution) So we should either fix the status of the bug, or open a new bug for the warning in vdsm log.
(In reply to Nir Soffer from comment #3) > This bug has two patches, only one of them is merged: > - http://gerrit.ovirt.org/31908 - merged > - http://gerrit.ovirt.org/32194 - new (there is a debate on the solution) > > So we should either fix the status of the bug, or open a new bug for the > warning in vdsm log. The latter.
Please provide verification steps. Thank you.
Jiri, You can create a new nfs storage domain, and check both logs. the expected result is that the log message : "vdsm oop WARNING renaming a directory is not an atomic operation" should appear in the vdsm log but not in /var/log/messages.
10:57 <jbelka> it's not merged the patch 10:57 <jbelka> http://gerrit.ovirt.org/#/c/32194/1/vdsm/storage/outOfProcess.py,unified 11:03 <ykaplan> the patch you are referring to is not merged yet so it's irrelevant
also http://gerrit.ovirt.org/31908 is not part of the build vdsm-4.16.3-3.el7.beta.x86_64
oVirt gerrit - 32194, is related to the bug, but is not the fix. In addition, backport to 3.5 of oVirt gerrit - 31908.
Only now merged to 3.5. please correct the "Fixed In Version" field after build
ok, vdsm-4.16.5-2.el6ev.x86_64 /var/log/messages doesn't contain the log line after vdsm got updated. ... Thread-14::DEBUG::2014-09-25 10:50:25,236::__init__::232::IOProcess::(_processLogs) (488) Got request for method 'rename' Thread-42::WARNING::2014-09-25 10:50:25,253::outOfProcess::221::Storage.oop::(rename) renaming a directory is not an atomic operation Thread-14::DEBUG::2014-09-25 10:50:25,254::__init__::232::IOProcess::(_processLogs) (496) Got request for method 'rename' # grep 'renam' /var/log/messages Sep 24 14:38:07 dell-r210ii-03 kernel: udev: renamed network interface eth0 to em1 Sep 24 14:38:07 dell-r210ii-03 kernel: udev: renamed network interface eth1 to em2 Sep 25 10:35:27 dell-r210ii-03 vdsm oop WARNING renaming a directory is not an atomic operation