Spec URL: https://gil.fedorapeople.org/json-path.spec SRPM URL: https://gil.fedorapeople.org/json-path-0.9.1-1.fc19.src.rpm Description: Java DSL for reading and testing JSON documents Fedora Account System Username: gil
Hmm, the package doesn't build in Rawhide due to test failures: http://koji.fedoraproject.org/koji/taskinfo?taskID=7438760 expected:<[{"o[ccupation":"Farm boy","name":"Luke Skywalker","aliases":["Nerf herder"],"offspring":null]}]> but was: <[{"o[ffspring":null,"aliases":["Nerf herder"],"occupation":"Farm boy","name":"Luke Skywalker"]}]> I guess this is Java 8 related and tests probably rely on particular ordering in set.
Spec URL: https://gil.fedorapeople.org/json-path.spec SRPM URL: https://gil.fedorapeople.org/json-path-0.9.1-2.fc19.src.rpm - disable failed tests on java 8 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7438898
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. See below. [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI Rpmlint ------- Checking: json-path-0.9.1-2.fc22.noarch.rpm json-path-javadoc-0.9.1-2.fc22.noarch.rpm json-path-0.9.1-2.fc22.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Requires -------- json-path-javadoc (rpmlib, GLIBC filtered): jpackage-utils json-path (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(net.minidev:json-smart) mvn(org.codehaus.jackson:jackson-mapper-asl) mvn(org.hamcrest:hamcrest-core) mvn(org.hamcrest:hamcrest-library) mvn(org.slf4j:slf4j-api) Provides -------- json-path-javadoc: json-path-javadoc json-path: json-path mvn(com.jayway.jsonpath:json-path) mvn(com.jayway.jsonpath:json-path-assert) mvn(com.jayway.jsonpath:json-path-assert:pom:) mvn(com.jayway.jsonpath:json-path-parent:pom:) mvn(com.jayway.jsonpath:json-path:pom:) osgi(com.jayway.jsonpath.json-path) Source checksums ---------------- https://github.com/jayway/JsonPath/archive/json-path-0.9.1.tar.gz : CHECKSUM(SHA256) this package : 06688e626c8a4f64ac408c066cf14c96b13ed93f33ce8143dfa074bb16db4ccb CHECKSUM(SHA256) upstream package : 06688e626c8a4f64ac408c066cf14c96b13ed93f33ce8143dfa074bb16db4ccb Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1131936 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ISSUES: The package looks good, but the license tag is not correct. Some files in src/main/java/com/jayway/jsonassert/impl/matcher/ are licensed under BSD, so the tag should be "ASL 2.0 and BSD" Please fix this issue at import time. APPROVED.
Spec URL: https://gil.fedorapeople.org/json-path.spec SRPM URL: https://gil.fedorapeople.org/json-path-0.9.1-2.fc19.src.rpm - fix license issues New Package SCM Request ======================= Package Name: json-path Short Description: Java JsonPath implementation Owners: gil Branches: f21 InitialCC: java-sig
Git done (by process-git-requests).
Thank for all! Task Info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7439354 Build Info: http://koji.fedoraproject.org/koji/buildinfo?buildID=570041