Red Hat Bugzilla – Bug 1132301
Error msg is not right for option -k and -K against virsh command
Last modified: 2015-03-05 02:43:00 EST
Description of problem: Version-Release number of selected component (if applicable): libvirt-1.2.7-1.el7.x86_64 qemu-kvm-rhev-2.1.0-1.el7.x86_64 kernel-3.10.0-142.el7.x86_64 How reproducible: 100% Steps to Reproduce: [root@rhel7 ~]# virsh -k -1 error: option --k requires a positive numeric argument [root@rhel7 ~]# virsh -K -2 error: option --K requires a positive numeric argument [root@rhel7 ~]# virsh --keepalive-interval=-1 error: option ---keepalive-interval requires a positive numeric argument [root@rhel7 ~]# virsh --keepalive-count=-2 error: option ---keepalive-count requires a positive numeric argument Actual results: 1. for -k option, error info is: error: option --k requires a positive numeric argument 2. for -K option, error info is: error: option --K requires a positive numeric argument 3. for --keepalive-interval option, error info is: error: option ---keepalive-count requires a positive numeric argument 4. for --keepalive-count option, error info is: error: option ---keepalive-count requires a positive numeric argument Expected results: 1. for -k option, error info should be: (not --k option in error info) error: option -k requires a positive numeric argument 2. for -K option, error info should be: (not --K option in error info) error: option -K requires a positive numeric argument 3. for --keepalive-interval option, error info should be: (not ---keepalive-interval option in error info) error: option --keepalive-interval requires a positive numeric argument 4. for --keepalive-count option, error info should be: (not ---keepalive-count option in error info) error: option --keepalive-count requires a positive numeric argument Additional info: From man page, zero are acceptable for options -k and -K, -k, --keepalive-interval INTERVAL Set an INTERVAL (in seconds) for sending keepalive messages to check whether connection to the server is still alive. Setting the interval to 0 disables client keepalive mechanism. -K, --keepalive-count COUNT Set a number of times keepalive message can be sent without getting an answer from the server without marking the connection dead. There is no effect to this setting in case the INTERVAL is set to 0. It is suggested that these error info should be just like: 1. error: option -k requires a positive numeric or zero argument 2. error: option -K requires a positive numeric or zero argument 3. error: option --keepalive-interval requires a positive numeric argument or zero argument 4. error: option --keepalive-count requires a positive numeric argument or zero argument
Fixed upstream: commit b470a38fa99a9567dc4a832d93f4aaf6cc782e0b Author: Peter Krempa <pkrempa@redhat.com> Date: Thu Aug 21 09:58:34 2014 +0200 virsh: Don't print extra '-'s in error message for -k and -K options The error message contains one extra dash. v1.2.7-189-gb470a38
Verified with build libvirt-1.2.8-1.el7.x86_64: [root@rhel7-a1 ~]# virsh -k -1 error: option -k requires a positive integer argument [root@rhel7-a1 ~]# virsh -K -1 error: option -K requires a positive integer argument [root@rhel7-a1 ~]# virsh --keepalive-interval=-1 error: option --keepalive-interval requires a positive integer argument [root@rhel7-a1 ~]# virsh --keepalive-count=-2 error: option --keepalive-count requires a positive integer argument Currently, the error message does not contain the extra dash.
I can produce this bug on build libvirt-1.2.7-1.el7.x86_64 verify it on build libvirt-1.2.8-9.el7.x86_64 verify steps: # virsh -k -1 error: option -k requires a positive integer argument # virsh --keepalive-interval=-1 error: option --keepalive-interval requires a positive integer argument # virsh -K -1 error: option -K requires a positive integer argument # virsh --keepalive-count=-1 error: option --keepalive-count requires a positive integer argument all error messages expected right move to verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-0323.html