RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1132301 - Error msg is not right for option -k and -K against virsh command
Summary: Error msg is not right for option -k and -K against virsh command
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.1
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Peter Krempa
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-21 06:18 UTC by zhengqin
Modified: 2015-03-05 07:43 UTC (History)
7 users (show)

Fixed In Version: libvirt-1.2.8-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 07:43:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description zhengqin 2014-08-21 06:18:43 UTC
Description of problem:


Version-Release number of selected component (if applicable):
libvirt-1.2.7-1.el7.x86_64
qemu-kvm-rhev-2.1.0-1.el7.x86_64
kernel-3.10.0-142.el7.x86_64


How reproducible:
100%

Steps to Reproduce:

[root@rhel7 ~]# virsh -k -1
error: option --k requires a positive numeric argument

[root@rhel7 ~]# virsh -K -2
error: option --K requires a positive numeric argument

[root@rhel7 ~]# virsh --keepalive-interval=-1
error: option ---keepalive-interval requires a positive numeric argument

[root@rhel7 ~]# virsh --keepalive-count=-2
error: option ---keepalive-count requires a positive numeric argument

Actual results:
1. for -k option, error info is:
error: option --k requires a positive numeric argument

2. for -K option, error info is:
error: option --K requires a positive numeric argument

3. for --keepalive-interval option, error info is:
error: option ---keepalive-count requires a positive numeric argument

4. for --keepalive-count option, error info is:
error: option ---keepalive-count requires a positive numeric argument

Expected results:
1. for -k option, error info should be:   (not --k option in error info)
error: option -k requires a positive numeric argument

2. for -K option, error info should be:   (not --K option in error info)
error: option -K requires a positive numeric argument

3. for --keepalive-interval option, error info should be:   (not
---keepalive-interval option in error info)
error: option --keepalive-interval requires a positive numeric argument

4. for --keepalive-count option, error info should be:   (not
---keepalive-count option in error info)
error: option --keepalive-count requires a positive numeric argument


Additional info:
 From man page, zero are acceptable for options -k and -K,

    -k, --keepalive-interval INTERVAL
            Set an INTERVAL (in seconds) for sending keepalive messages
to check whether connection to the server is still alive. Setting the
interval to 0 disables client
            keepalive mechanism.

    -K, --keepalive-count COUNT
            Set a number of times keepalive message can be sent without
getting an answer from the server without marking the connection dead.
There is no effect to this
            setting in case the INTERVAL is set to 0.

It is suggested that these error info should be just like:
1. error: option -k requires a positive numeric or zero argument
2. error: option -K requires a positive numeric or zero argument
3. error: option --keepalive-interval requires a positive numeric
argument or zero argument
4. error: option --keepalive-count requires a positive numeric argument
or zero argument

Comment 1 Peter Krempa 2014-08-21 08:04:33 UTC
Fixed upstream:

commit b470a38fa99a9567dc4a832d93f4aaf6cc782e0b
Author: Peter Krempa <pkrempa>
Date:   Thu Aug 21 09:58:34 2014 +0200

    virsh: Don't print extra '-'s in error message for -k and -K options
    
    The error message contains one extra dash.

v1.2.7-189-gb470a38

Comment 3 zhengqin 2014-09-10 05:13:37 UTC
Verified with build libvirt-1.2.8-1.el7.x86_64:

[root@rhel7-a1 ~]# virsh -k -1
error: option -k requires a positive integer argument
[root@rhel7-a1 ~]# virsh -K -1
error: option -K requires a positive integer argument
[root@rhel7-a1 ~]#  virsh --keepalive-interval=-1
error: option --keepalive-interval requires a positive integer argument
[root@rhel7-a1 ~]#  virsh --keepalive-count=-2
error: option --keepalive-count requires a positive integer argument


Currently, the error message does not contain the extra dash.

Comment 5 vivian zhang 2014-12-01 02:20:27 UTC
I can produce this bug on build libvirt-1.2.7-1.el7.x86_64

verify it on build
libvirt-1.2.8-9.el7.x86_64

verify steps:

# virsh -k -1
error: option -k requires a positive integer argument
# virsh --keepalive-interval=-1
error: option --keepalive-interval requires a positive integer argument
# virsh -K -1
error: option -K requires a positive integer argument
# virsh --keepalive-count=-1
error: option --keepalive-count requires a positive integer argument

all error messages expected right

move to verified

Comment 7 errata-xmlrpc 2015-03-05 07:43:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html


Note You need to log in before you can comment on or make changes to this bug.