Description of problem: Trash translator is a new feature which is used to store files removed from the mount point.This bug is to track changes related to trash translator
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#7) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#8) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#9) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#10) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#11) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#12) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#13) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#14) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#15) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#16) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#17) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (features/trash : Combined patches for trash translator) posted (#18) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#19) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#20) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/8312 (Features/trash : Combined patches for trash translator) posted (#21) for review on master by Anoop C S (achiraya)
COMMIT: http://review.gluster.org/8312 committed in master by Vijay Bellur (vbellur) ------ commit 0ef870741a2f49d47a02725aed13a95335a6e42f Author: Anoop C S <achiraya> Date: Fri Feb 27 15:14:08 2015 +0530 Features/trash : Combined patches for trash translator This is the combined patch set for supporting trash feature. http://www.gluster.org/community/documentation/index.php/Features/Trash Current patch includes the following features: * volume set options for enabling trash globally and exclusively for internal operations like self-heal and re-balance * volume set options for setting the eliminate path, trash directory path and maximum trashable file size. * test script for checking the functionality of the feature * brief documentation on different aspects of trash feature. Change-Id: Ic7486982dcd6e295d1eba0f4d5ee6d33bf1b4cb3 BUG: 1132465 Signed-off-by: Anoop C S <achiraya> Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: http://review.gluster.org/8312 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/9909 (features/trash: Avoid unnecessary logging from trash_local_wipe) posted (#1) for review on master by Anoop C S (achiraya)
COMMIT: http://review.gluster.org/9909 committed in master by Vijay Bellur (vbellur) ------ commit 33944a3eb3b589b1d309826b5f431497924ac3ae Author: Anoop C S <achiraya> Date: Tue Mar 17 16:29:53 2015 +0530 features/trash: Avoid unnecessary logging from trash_local_wipe Even when trash translator is disabled, the following error is being logged for each unlink/truncate/ftruncate calls. [...] E [trash.c:221:trash_local_wipe] (--> ... ... ) 0-trash: invalid argument: local This change replaces GF_VALIDATE_OR_GOTO macro with simple if condition. Change-Id: I7e6754cd53ec7c2d84669b6d40d883a2d1eee41e BUG: 1132465 Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/9909 Reviewed-by: jiffin tony Thottan <jthottan> Reviewed-by: Vijay Bellur <vbellur> Tested-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/9926 (features/trash: Handling hardlinks in trash translator) posted (#1) for review on master by jiffin tony Thottan (jthottan)
COMMIT: http://review.gluster.org/9926 committed in master by Vijay Bellur (vbellur) ------ commit 191ab5693d3c9a0cdedc66bb24dd5efa535963d9 Author: Jiffin Tony Thottan <jthottan> Date: Wed Mar 18 14:12:03 2015 +0530 features/trash: Handling hardlinks in trash translator In the current code of trash translator, file is moved to trash directory without checking whether it is the last hardlink.This may lead to inconsistency for a file in that gluster volume.To avoid those scenarios,so a file is moved to trash directory only if it is the last hardlink. Change-Id: Id098e53a2236c6406ef91e6e2599ea2cff9bace3 BUG: 1132465 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: http://review.gluster.org/9926 Reviewed-by: Anoop C S <achiraya> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Kaleb KEITHLEY <kkeithle> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/9984 (features/trash : Discarding extended truncate for trash-translator) posted (#1) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/9984 (features/trash : Discarding extended truncate for trash-translator) posted (#2) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10002 (features/trash: Removing ftruncate dead callbacks) posted (#1) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/10002 (features/trash: Removing dead callbacks) posted (#2) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/9984 (features/trash : Discarding extended truncate for trash-translator) posted (#3) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10002 (features/trash: Removing dead callbacks) posted (#3) for review on master by Anoop C S (achiraya)
COMMIT: http://review.gluster.org/10002 committed in master by Vijay Bellur (vbellur) ------ commit bc71cc39881730c8592718a5045a744387bfaea4 Author: Anoop C S <achiraya> Date: Thu Mar 26 12:00:39 2015 +0530 features/trash: Removing dead callbacks Since ftruncate create, mkdir, writev, readv and unlink calls are being re-directed to corresponding truncate calls, we no longer need their cbks. So removing those cbks for now. Change-Id: I41ecde7093a555b3bf69b66afaa8eca835b4982a BUG: 1132465 Signed-off-by: Anoop C S <achiraya> Reviewed-on: http://review.gluster.org/10002 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: jiffin tony Thottan <jthottan> Reviewed-by: Vijay Bellur <vbellur>
COMMIT: http://review.gluster.org/9984 committed in master by Vijay Bellur (vbellur) ------ commit 3db5f3a41b7029ce8005d1e1cc01808a15cc6019 Author: Jiffin Tony Thottan <jthottan> Date: Tue Mar 24 16:29:13 2015 +0530 features/trash : Discarding extended truncate for trash-translator Change-Id: I5c571cbb2d6da1e95831ec206639926722a9d281 BUG: 1132465 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: http://review.gluster.org/9984 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anoop C S <achiraya> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir option) posted (#1) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir option) posted (#2) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir option) posted (#3) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir option) posted (#4) for review on master by Vijay Bellur (vbellur)
REVIEW: http://review.gluster.org/10215 (features/trash : fixing trash dir option) posted (#5) for review on master by jiffin tony Thottan (jthottan)
COMMIT: http://review.gluster.org/10215 committed in master by Vijay Bellur (vbellur) ------ commit ee255e239aaa1ed5f6388c48a8919989535f3dcc Author: Jiffin Tony Thottan <jthottan> Date: Mon Apr 13 15:23:51 2015 +0530 features/trash : fixing trash dir option Previously, problem was caused due to buffer overflow of variable used in the code. This patch fix the same. Change-Id: I3df5e06044470022f9475d93d33447db35384da2 BUG: 1132465 Signed-off-by: Jiffin Tony Thottan <jthottan> Reviewed-on: http://review.gluster.org/10215 Tested-by: NetBSD Build System Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Anoop C S <achiraya> Reviewed-by: Vijay Bellur <vbellur>
REVIEW: http://review.gluster.org/10387 (features/trash : avoid unnecessary logging by trash translator when volume is started) posted (#1) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10387 (features/trash : avoid unnecessary logging by trash translator when volume is started) posted (#2) for review on master by jiffin tony Thottan (jthottan)
REVIEW: http://review.gluster.org/10387 (features/trash : Avoid unnecessary logging from trash translator) posted (#3) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/10387 (features/trash : Avoid unnecessary logging from trash translator) posted (#4) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/10387 (features/trash : Avoid unnecessary logging from trash translator) posted (#5) for review on master by Anoop C S (achiraya)
REVIEW: http://review.gluster.org/10387 (features/trash : Avoid unnecessary logging from trash translator) posted (#7) for review on master by Anoop C S (achiraya)
Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.