Bug 1132469 - [AFR-V2] - Type mismatch of inode does not report EIO
Summary: [AFR-V2] - Type mismatch of inode does not report EIO
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1136830
TreeView+ depends on / blocked
 
Reported: 2014-08-21 12:11 UTC by Krutika Dhananjay
Modified: 2015-05-14 17:43 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Clone Of:
: 1136830 (view as bug list)
Environment:
Last Closed: 2015-05-14 17:27:16 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2014-08-21 12:11:09 UTC
Description of problem:

When an inode's type is mismatching across the subvolumes of AFR, operations on it must not succeed and must fail with EIO.

Version-Release number of selected component (if applicable):
AFR-V2

How reproducible:
Always

Steps to Reproduce:
1. Create, start and mount a replicate volume.
2. 'mkdir foo' on the mountpoint.
3. Go to one of the bricks, do 'rm -rf foo', and perform 'touch foo'.
4. Perform 'ls -lR' on the mount point. Observe file type.

Actual results:

No error is reported on the mountpoint.
The inode is listed as a regular file.
But a stat on foo reports that foo is a directory.
echo 123 > /mnt/foo fails with EISDIR.
mkdir foo/bar succeeds.
From this point on, foo is listed as directory on doing ls -l.
foo continues to be a regular file on the brick where step 3 was performed.

Expected results:
Operations on such an inode where the replicas are not in agreement with respect to its type, must fail with EIO.

Additional info:
The test returns EIO (as expected) on AFR-V1.

Comment 1 Anand Avati 2014-09-01 11:18:04 UTC
REVIEW: http://review.gluster.org/8574 (cluster/afr: Propagate EIO on inode's type mismatch) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2014-09-02 08:34:45 UTC
REVIEW: http://review.gluster.org/8574 (cluster/afr: Propagate EIO on inode's type mismatch) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Anand Avati 2014-09-02 12:47:51 UTC
REVIEW: http://review.gluster.org/8574 (cluster/afr: Propagate EIO on inode's type mismatch) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Anand Avati 2014-09-02 14:57:31 UTC
COMMIT: http://review.gluster.org/8574 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 6c4325ca57bca72d10e5172f8423262cdb3a379c
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Aug 21 17:27:17 2014 +0530

    cluster/afr: Propagate EIO on inode's type mismatch
    
    Original author of the test script:
                Pranith Kumar K <pkarampu>
    
    Change-Id: If515ecefd3c17f85f175b6a8cb4b78ce8c916de2
    BUG: 1132469
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8574
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>

Comment 5 Anand Avati 2014-09-03 09:08:06 UTC
REVIEW: http://review.gluster.org/8586 (cluster/afr: Minor fixes to #8574) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 6 Anand Avati 2014-09-03 11:10:41 UTC
COMMIT: http://review.gluster.org/8586 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 1f094f2519c163bd033ab535555448db34e9804d
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Sep 2 21:05:56 2014 +0530

    cluster/afr: Minor fixes to #8574
    
    * Fixed a bug in afr_selfheal_name_type_mismatch_check()
    * Fixed indentation
    * Removed redundant 'continue' statements
    
    Change-Id: Ie58b5dec9085ce9fe46ae9f244ebae1b1cef7ac5
    BUG: 1132469
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8586
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>

Comment 7 Niels de Vos 2015-05-14 17:27:16 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:35:33 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:37:55 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:43:18 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.