Created attachment 929850 [details] patch to fix swap creation as first partition Description of problem: When using a kickstart that specifies a swap as the first partition, creation fails. Changing this to the second after an ext[2-4] (and probably vfat) fixes this. This prevents users creating cloud images with expandable rootdisks + swap. Version-Release number of selected component (if applicable): appliance-tools-007.4-1.fc20.noarch How reproducible: Every time - just follow the steps Steps to Reproduce: 1. Used provided fedora 20 cloud image kickstart. Others will probably do the same. 2. Add a part swap --size 2048 (or equivalent) line before the / part 3. Run appliance--creator Actual results: Will fail with: File "/usr/lib/python2.7/site-packages/appcreate/partitionedfs.py", line 112, in __format_disks p['type'], fstype, "%dM" % p['start'], "%dM" % (p['start']+p['size'])]) UnboundLocalError: local variable 'fstype' referenced before assignment Expected results: Successful creation of disk image with part1 as swap, part2 as / Additional info: Here's the fix (attached) - let's look at the mountpoint and let parted know it's linux-swap. fstype isn't defaulted at all in this function - that may also be a bug? The hardcoded nature of ext2 and vfat here might prevent other fs (btrfs, xfs) being used.
This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 20 changed to end-of-life (EOL) status on 2015-06-23. Fedora 20 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.