Bug 1133694 - App vhost proxy directives need to use slashes consistently
Summary: App vhost proxy directives need to use slashes consistently
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Online
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 2.x
Assignee: Rajat Chopra
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1133494
TreeView+ depends on / blocked
 
Reported: 2014-08-25 21:04 UTC by Andy Goldstein
Modified: 2015-05-14 23:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-10-10 00:51:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Andy Goldstein 2014-08-25 21:04:30 UTC
When the vhost plugin creates conf files for the node Apache containing the ProxyPass and ProxyPassReverse directives, it does not currently ensure that the arguments are consistent with trailing slashes. For example:

# ELEMENT: ["/ZendServer","127.1.246.129:16081/ZendServer",{"protocols":["http","ws"]}]
ProxyPass /ZendServer http://127.1.246.129:16081/ZendServer/ retry=0
ProxyPassReverse /ZendServer http://127.1.246.129:16081/ZendServer/
ProxyPassReverse /ZendServer http://z2-agold.dev.rhcloud.com/ZendServer

If the first URL (/ZendServer) has no trailing slash, the second URL must also have no trailing slash. Similarly if the first URL has a trailing slash, the second URL must also have a trailing slash. In the example above, the ProxyPass line is incorrect because the slashes don't match. The only line that is correct is the final line because both /ZendServer and http://z2-agold.dev.rhcloud.com/ZendServer have no trailing slashes.

Comment 2 Yan Du 2014-08-26 05:25:56 UTC
Test on devenv-stage_980

$ cat 599988_element-_ZendServer.conf
# ELEMENT: ["/ZendServer","127.1.244.129:16081/ZendServer",{"protocols":["http","ws"]}]
ProxyPass /ZendServer http://127.1.244.129:16081/ZendServer retry=0
ProxyPassReverse /ZendServer http://127.1.244.129:16081/ZendServer
ProxyPassReverse /ZendServer http://zend-a.dev.rhcloud.com/ZendServer

Move bug to verified.


Note You need to log in before you can comment on or make changes to this bug.