Bug 1134351 - Review Request: perl-Module-Install-TestBase - Module::Install Support for Test::Base
Summary: Review Request: perl-Module-Install-TestBase - Module::Install Support for Te...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/ingydotnet/module-...
Whiteboard:
Depends On:
Blocks: 1134289
TreeView+ depends on / blocked
 
Reported: 2014-08-27 11:22 UTC by Petr Pisar
Modified: 2014-09-23 04:34 UTC (History)
2 users (show)

Fixed In Version: perl-Module-Install-TestBase-0.86-2.fc21
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-23 04:34:20 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2014-08-27 11:22:45 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Module-Install-TestBase/perl-Module-Install-TestBase.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Module-Install-TestBase/perl-Module-Install-TestBase-0.86-1.fc22.src.rpm
Description:
This Perl module adds the use_test_base directive to Module::Install. Now you
can get full Test-Base support for you module with no external dependency on
Test::Base.

Fedora Account System Username: ppisar


This package will get into Fedora ≥ 21 to provide modules removed from perl-Test-Base.

Comment 1 David Dick 2014-08-27 20:57:19 UTC
License is correct.

package builds in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7469312

build and runtime requires are good.  might be worth filing a bug against upstream for all of the non-declared dependencies (Spiffy at least is non-core).

as this module is for f21+, it would be a good candidate for NO_PACKLIST in the Makefile.PL line.

rpmlint is clean

package approved!

Comment 2 Petr Pisar 2014-08-28 06:49:13 UTC
New Package SCM Request
=======================
Package Name: perl-Module-Install-TestBase
Short Description: Module::Install Support for Test::Base
Upstream URL: http://search.cpan.org/dist/Module-Install-TestBase/
Owners: ppisar jplesnik psabata
Branches: f21
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2014-08-28 11:54:25 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2014-08-28 12:20:18 UTC
Thank you for the review and the repository. I reported the metadata issue to the upstream.

Comment 5 Petr Pisar 2014-08-28 12:46:29 UTC
F21 does not have latest Module::Install::Base 1.10. The exact version is probably a bug caused by upstream release tools <https://github.com/ingydotnet/module-install-testbase-pm/issues/2>. I will remove the version constrain.

Comment 6 Fedora Update System 2014-08-29 13:26:14 UTC
perl-Module-Install-TestBase-0.86-2.fc21,perl-Makefile-DOM-0.006-9.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Module-Install-TestBase-0.86-2.fc21,perl-Makefile-DOM-0.006-9.fc21

Comment 7 Fedora Update System 2014-08-29 14:43:21 UTC
Package perl-Module-Install-TestBase-0.86-2.fc21, perl-Makefile-DOM-0.006-9.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-Module-Install-TestBase-0.86-2.fc21 perl-Makefile-DOM-0.006-9.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-9915/perl-Module-Install-TestBase-0.86-2.fc21,perl-Makefile-DOM-0.006-9.fc21
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2014-09-23 04:34:20 UTC
perl-Module-Install-TestBase-0.86-2.fc21, perl-Makefile-DOM-0.006-9.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.