Bug 1134376 - Review Request: python-XStatic-Angular-Mock - Angular-Mock (XStatic packaging standard)
Summary: Review Request: python-XStatic-Angular-Mock - Angular-Mock (XStatic packaging...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Haïkel Guémar
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 1134565
TreeView+ depends on / blocked
Reported: 2014-08-27 12:16 UTC by Matthias Runge
Modified: 2014-09-27 18:43 UTC (History)
2 users (show)

Fixed In Version: python-XStatic-Angular-Mock-
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2014-09-19 10:16:05 UTC
Type: ---
karlthered: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Matthias Runge 2014-08-27 12:16:06 UTC
Spec URL: http://www.matthias-runge.de/fedora/python-XStatic-Angular-Mock.spec
SRPM URL: http://www.matthias-runge.de/fedora/python-XStatic-Angular-Mock-
Description: Angular-Mock JavaScript library
packaged for setuptools (easy_install) / pip.

Fedora Account System Username: mrunge

Koji scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7465920

Comment 2 Haïkel Guémar 2014-09-05 08:35:31 UTC
There's a typo in the provided spec (no need to bump spec)
=> %changelogA

Comment 4 Haïkel Guémar 2014-09-05 12:28:17 UTC
No problem :)

As for the other XStatic packages, don't forget to request upstream to include the license file.
Since this packages complies with Fedora packaging guidelines, I hereby approve it into Fedora Packages Collection. Please submit a scm request.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[-]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 4 files have unknown license. Detailed output of
     licensecheck in /home/haikel/1134376-python-XStatic-Angular-
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python2.7/site-packages/xstatic/pkg
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python2.7/site-
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Checking: python-XStatic-Angular-Mock-
python-XStatic-Angular-Mock.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
python-XStatic-Angular-Mock.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
# rpmlint python-XStatic-Angular-Mock
python-XStatic-Angular-Mock.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, footstools
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'

python-XStatic-Angular-Mock (rpmlib, GLIBC filtered):


Source checksums
https://pypi.python.org/packages/source/X/XStatic-Angular-Mock/XStatic-Angular-Mock- :
  CHECKSUM(SHA256) this package     : ffee6edfab8276abd8057ddc28c4d8503424c0c61938e787720766862ef43e42
  CHECKSUM(SHA256) upstream package : ffee6edfab8276abd8057ddc28c4d8503424c0c61938e787720766862ef43e42

Comment 5 Matthias Runge 2014-09-09 10:44:31 UTC
Thank you for your review!

New Package SCM Request
Package Name: python-XStatic-Angular-Mock
Short Description: Angular-Mock (XStatic packaging standard)
Upstream URL: http://angularjs.org/
Owners: mrunge
Branches: f20 f21 epel7

Comment 6 Gwyn Ciesla 2014-09-09 11:50:32 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-09-10 07:31:23 UTC
python-XStatic-Angular-Mock- has been submitted as an update for Fedora 20.

Comment 8 Fedora Update System 2014-09-10 07:32:42 UTC
python-XStatic-Angular-Mock- has been submitted as an update for Fedora EPEL 7.

Comment 9 Fedora Update System 2014-09-10 07:33:04 UTC
python-XStatic-Angular-Mock- has been submitted as an update for Fedora 21.

Comment 10 Fedora Update System 2014-09-10 16:41:41 UTC
python-XStatic-Angular-Mock- has been pushed to the Fedora 21 testing repository.

Comment 11 Fedora Update System 2014-09-19 10:16:05 UTC
python-XStatic-Angular-Mock- has been pushed to the Fedora 20 stable repository.

Comment 12 Fedora Update System 2014-09-23 04:23:33 UTC
python-XStatic-Angular-Mock- has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2014-09-27 18:43:15 UTC
python-XStatic-Angular-Mock- has been pushed to the Fedora EPEL 7 stable repository.

Note You need to log in before you can comment on or make changes to this bug.