Bug 1134382 - Cleanup after failed snapshot disk removal ends with Null Pointer Exception
Summary: Cleanup after failed snapshot disk removal ends with Null Pointer Exception
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.5.0
Assignee: Daniel Erez
QA Contact: Kevin Alon Goldblatt
URL:
Whiteboard: storage
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-27 12:31 UTC by Kevin Alon Goldblatt
Modified: 2016-02-10 19:43 UTC (History)
7 users (show)

Fixed In Version: ovirt-3.5.0_rc2
Clone Of:
Environment:
Last Closed: 2014-10-17 12:42:24 UTC
oVirt Team: Storage
Embargoed:


Attachments (Terms of Use)
engine vdsm and server logs (1.11 MB, application/octet-stream)
2014-08-27 12:32 UTC, Kevin Alon Goldblatt
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 32143 0 master MERGED core: RemoveDiskSnapshot rollback - fetch disk by DiskDao Never
oVirt gerrit 32173 0 ovirt-engine-3.5 MERGED core: RemoveDiskSnapshot rollback - fetch disk by DiskDao Never

Description Kevin Alon Goldblatt 2014-08-27 12:31:27 UTC
Description of problem:
When deleting the snapshot disks and reboot the host during this operation the EndAction for RemoveSnapshotDisks end with a Null Pointer Exception

Version-Release number of selected component (if applicable):
ovirt-engine-3.5.0-0.0.master.20140821064931.gitb794d66.el6.noarch
vdsm-4.16.1-6.gita4a4614.el6.x86_64

How reproducible:
All the time

Steps to Reproduce:
1.add vm + 3 disks,create a snapshot
2.add another 2 disks and create another snapshot
3.select all volumes from snapshot overview and remove them
4.during removal reboot host

Actual results:
The endAction for action type RemoveDiskSnapshots threw an exception

Expected results:
The End Action should have completed and rolled back the failed delete operation

Additional info:
FROM ENGINE LOG>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>...
https://tcms.engineering.redhat.com/run/163708/
n of Disk 'vm10_Disk5' from snapshot(s) 'vm10_snap2' of VM 'vm10' (User: admin).
2014-08-27 10:34:49,578 ERROR [org.ovirt.engine.core.bll.tasks.CommandAsyncTask] (org.ovirt.thread.pool-8-thread-47) [within thread]: endAction for action type RemoveDiskSnapshots threw an exception.: java.lang.NullPointerException
        at org.ovirt.engine.core.bll.RemoveDiskSnapshotTaskHandler.endWithFailure(RemoveDiskSnapshotTaskHandler.java:103) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.internalEndWithFailure(CommandBase.java:653) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.endActionInTransactionScope(CommandBase.java:566) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:1923) [bll.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInNewTransaction(TransactionSupport.java:210) [utils.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInRequired(TransactionSupport.java:149) [utils.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:118) [utils.jar:]
        at org.ovirt.engine.core.bll.CommandBase.endAction(CommandBase.java:494) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.DecoratedCommand.endAction(DecoratedCommand.java:17) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CoCoAsyncTaskHelper.endAction(CoCoAsyncTaskHelper.java:323) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandCoordinatorImpl.endAction(CommandCoordinatorImpl.java:350) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandAsyncTask.endCommandAction(CommandAsyncTask.java:149) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandAsyncTask.access$000(CommandAsyncTask.java:28) [bll.jar:]
        at org.ovirt.engine.core.bll.tasks.CommandAsyncTask$1.run(CommandAsyncTask.java:109) [bll.jar:]
        at org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:90) [utils.jar:]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [rt.jar:1.7.0_55]
        at java.util.concurrent.FutureTask.run(FutureTask.java:262) [rt.jar:1.7.0_55]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_55]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_55]
        at java.lang.Thread.run(Thread.java:744) [rt.jar:1.7.0_55]

Comment 1 Kevin Alon Goldblatt 2014-08-27 12:32:43 UTC
Created attachment 931438 [details]
engine vdsm and server logs

Comment 2 Kevin Alon Goldblatt 2014-10-01 14:32:26 UTC
I ran the scenario above and this time the disks delete operations failed and the rollback / cleanup was successful. Moving to Verified!

Comment 3 Sandro Bonazzola 2014-10-17 12:42:24 UTC
oVirt 3.5 has been released and should include the fix for this issue.


Note You need to log in before you can comment on or make changes to this bug.