1134494 – Should cleanly handle exception when repo can't be found

Bug 1134494 - Should cleanly handle exception when repo can't be found

Summary: Should cleanly handle exception when repo can't be found

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	Red Hat Satellite
Classification:	Red Hat
Component:	API
Sub Component:
Version:	6.0.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	unspecified
Target Milestone:	Unspecified
Assignee:	satellite6-bugs
QA Contact:	Katello QA List
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	sat6-pulp-future
TreeView+	depends on / blocked

Reported:	2014-08-27 15:34 UTC by Corey Welton
Modified:	2019-09-26 13:50 UTC (History)
CC List:	1 user (show)
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:	2014-11-24 21:33:37 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Description Corey Welton 2014-08-27 15:34:27 UTC

Description of problem:
in satellite capsules, when trying to initially check and see if repo exists (and it doesn't), a big trace is thrown.  ideally, we should handle this rather than throwing three pages of trace.


Version-Release number of selected component (if applicable):
pulp-katello-0.3-3.el7sat.noarch
pulp-nodes-child-2.4.0-0.30.beta.el7sat.noarch
pulp-nodes-common-2.4.0-0.30.beta.el7sat.noarch
pulp-nodes-parent-2.4.0-0.30.beta.el7sat.noarch
pulp-puppet-plugins-2.4.0-0.30.beta.el7sat.noarch
pulp-rpm-handlers-2.4.0-0.30.beta.el7sat.noarch
pulp-rpm-plugins-2.4.0-0.30.beta.el7sat.noarch
pulp-selinux-2.4.0-0.30.beta.el7sat.noarch
pulp-server-2.4.0-0.30.beta.el7sat.noarch
python-isodate-0.5.0-1.pulp.el7sat.noarch
python-kombu-3.0.15-12.pulp.el7sat.noarch
python-pulp-agent-lib-2.4.0-0.30.beta.el7sat.noarch
python-pulp-bindings-2.4.0-0.30.beta.el7sat.noarch
python-pulp-common-2.4.0-0.30.beta.el7sat.noarch
python-pulp-puppet-common-2.4.0-0.30.beta.el7sat.noarch
python-pulp-rpm-common-2.4.0-0.30.beta.el7sat.noarch
rubygem-smart_proxy_pulp-1.0.1-1.1.el7sat.noarch


How reproducible:


Steps to Reproduce:
1.  Attempt, for the first time, to sync a repo that does not exist on server.
2.  View logs


Actual results:

Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR: Missing resource(s): repository=Default_Organization-Library-mycv
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR: Traceback (most recent call last):
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/middleware/exception.py", line 44, in __call__
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return self.app(environ, start_response)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/middleware/postponed.py", line 42, in __call__
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return self.app(environ, start_response)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 279, in wsgi
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     result = self.handle_with_processors()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 29, in _handle_with_processors
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return process(self.processors)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 566, in processor
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return handler()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in <lambda>
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 581, in processor
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     result = handler()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in <lambda>
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 581, in processor
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     result = handler()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in <lambda>
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 28, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return self.handle()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 230, in handle
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return self._delegate(fn, self.fvars, args)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 422, in _delegate
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return f()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 430, in <lambda>
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     f = lambda: self._delegate_sub_application(pat, what)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 455, in _delegate_sub_application
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return app.handle_with_processors()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 29, in _handle_with_processors
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return process(self.processors)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 566, in processor
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return handler()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in <lambda>
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 581, in processor
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     result = handler()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 26, in <lambda>
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return p(lambda: process(processors))
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/application.py", line 28, in process
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return self.handle()
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 230, in handle
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return self._delegate(fn, self.fvars, args)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 420, in _delegate
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return handle_class(cls)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/web/application.py", line 396, in handle_class
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     return tocall(*args)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/controllers/decorators.py", line 227, in _auth_decorator
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     value = method(self, *args, **kwargs)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/webservices/controllers/repositories.py", line 338, in GET
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     importer = importer_manager.get_importer(repo_id)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:   File "/usr/lib/python2.7/site-packages/pulp/server/managers/repo/importer.py", line 46, in get_importer
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR:     raise MissingResource(repository=repo_id)
Aug 27 17:13:52 ibm-x3550m3-13 pulp: pulp.server.webservices.middleware.exception:ERROR: MissingResource: Missing resource(s): repository=Default_Organization-Library-mycv


...and so forth.

Expected results:

Handle exception, do not throw trace.

Additional info:

Comment 1 Jeremy Cline 2014-08-27 18:21:55 UTC

This should be fixed by https://github.com/pulp/pulp/pull/1113

Comment 2 Chris Duryee 2014-09-30 13:52:47 UTC

build: 2.5.0-0.6.beta

Comment 3 Preethi Thomas 2014-10-09 19:26:55 UTC

verified
[root@cloud-qe-15 ~]# rpm -qa pulp-server
pulp-server-2.5.0-0.7.beta.el7.noarch
[root@cloud-qe-15 ~]# 

[root@cloud-qe-15 ~]# rpm -qa |grep pulp-nodes
pulp-nodes-admin-extensions-2.5.0-0.7.beta.el7.noarch
pulp-nodes-parent-2.5.0-0.7.beta.el7.noarch
pulp-nodes-common-2.5.0-0.7.beta.el7.noarch
[root@cloud-qe-15 ~]# 


Oct  9 15:21:52 mgmt4 goferd: [INFO][worker-0] gofer.rmi.dispatcher:612 - call: Content.update() sn=3d32dced-088d-4e1c-8eed-c80c62240615 info={'task_id': '8543ad07-3981-44e5-ad25-90d849dfbee6', 'consumer_id': 'rhel6-pulp'}
Oct  9 15:21:52 mgmt4 pulp: pulp.server.webservices.middleware.exception:INFO: Missing resource(s): repo=zoo
Oct  9 15:21:52 mgmt4 goferd: [INFO][worker-0] pulp_node.handlers.model:384 - Distributor: zoo/yum_distributor, added
Oct  9 15:21:52 mgmt4 goferd: [INFO][worker-0] pulp_node.handlers.model:384 - Distributor: zoo/export_distributor, added
Oct  9 15:21:52 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.async.tasks._reserve_resource[0a170612-b404-4612-8145-7def303a975d]
Oct  9 15:21:52 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.async.tasks._reserve_resource[0a170612-b404-4612-8145-7def303a975d] succeeded in 0.0336200960446s: u'reserved_resource_worker-1.lab.eng.bos.redhat.com.dq'
Oct  9 15:21:53 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.managers.repo.importer.set_importer[fabb1a48-1936-487a-bf19-c22b2b529d56]
Oct  9 15:21:53 mgmt4 goferd: [INFO][worker-0] pulp_node.handlers.model:465 - Importer zoo/nodes_http_importer, added
Oct  9 15:21:53 mgmt4 goferd: [INFO][worker-0] pulp_node.handlers.model:186 - Repository: zoo, added
Oct  9 15:21:53 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.managers.repo.importer.set_importer[fabb1a48-1936-487a-bf19-c22b2b529d56] succeeded in 0.0426719710231s: {'repo_id': u'zoo', '_ns': u'repo_importers', 'importer_type_id': 'nodes_http_importer', 'last_sync': None,...
Oct  9 15:21:53 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.async.tasks._reserve_resource[7461bf70-b473-4043-8549-e76ea9ec6a10]
Oct  9 15:21:53 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.async.tasks._reserve_resource[7461bf70-b473-4043-8549-e76ea9ec6a10] succeeded in 0.0403233889956s: u'reserved_resource_worker-1.lab.eng.bos.redhat.com.dq'
Oct  9 15:21:54 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.tasks.repository.sync_with_auto_publish[9837fa78-99dd-450e-93f6-71583622d308]
Oct  9 15:21:54 mgmt4 pulp: requests.packages.urllib3.connectionpool:INFO: Starting new HTTPS connection (1): cloud-qe-15.idmqe.lab.eng.bos.redhat.com
Oct  9 15:21:55 mgmt4 pulp: requests.packages.urllib3.connectionpool:INFO: Starting new HTTPS connection (1): cloud-qe-15.idmqe.lab.eng.bos.redhat.com
Oct  9 15:21:56 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.async.tasks._reserve_resource[2120cc06-fa12-4e37-adf3-063193f8fcae]
Oct  9 15:21:56 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.async.tasks._reserve_resource[2120cc06-fa12-4e37-adf3-063193f8fcae] succeeded in 0.042650182033s: u'reserved_resource_worker-1.lab.eng.bos.redhat.com.dq'
Oct  9 15:21:56 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.managers.repo.publish.publish[c2cf8c70-03c0-421c-9440-b4df5be30e50]
Oct  9 15:21:57 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.async.tasks._queue_release_resource[39ea5ef0-93d7-4022-a309-49e9ad4936f1]
Oct  9 15:21:57 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.tasks.repository.sync_with_auto_publish[9837fa78-99dd-450e-93f6-71583622d308] succeeded in 2.97344290593s: <pulp.server.async.tasks.TaskResult object at 0x2ed6550>
Oct  9 15:21:57 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.managers.repo.publish.publish[c2cf8c70-03c0-421c-9440-b4df5be30e50] succeeded in 0.180002889945s: {'exception': None, 'repo_id': u'zoo', 'traceback': None, 'started': '2014-10-09T19:21:57Z', '_ns': u'repo_publish_results',...
Oct  9 15:21:57 mgmt4 pulp: celery.worker.strategy:INFO: Received task: pulp.server.async.tasks._release_resource[c4091c5a-6798-46eb-bfab-f3892f068624]
Oct  9 15:21:57 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.async.tasks._queue_release_resource[39ea5ef0-93d7-4022-a309-49e9ad4936f1] succeeded in 0.0124934649793s: None
Oct  9 15:21:57 mgmt4 pulp: celery.worker.job:INFO: Task pulp.server.async.tasks._release_resource[c4091c5a-6798-46eb-bfab-f3892f068624] succeeded in 0.036265041912s: None
Oct  9 15:21:57 mgmt4 goferd: [INFO][worker-0] gofer.agent.rmi:149 - sn=3d32dced-088d-4e1c-8eed-c80c62240615 processed in: 5.451 (seconds)

Note You need to log in before you can comment on or make changes to this bug.