Spec URL: https://fedorapeople.org/~jamielennox/python-requests-mock.spec SRPM URL: https://fedorapeople.org/~jamielennox/python-requests-mock-0.5.1-1.fc20.src.rpm Description: requests-mock provides a simple way to do HTTP mocking at the python-requests layer. Fedora Account System Username: jamielennox rpmlint SPECS/python-requests-mock.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
Successful Koji scratch build: $ koji build --scratch rawhide /home/kashyap/rpmbuild/SRPMS/python-requests-mock-0.5.1-1.fc20.src.rpm Uploading srpm: /home/kashyap/rpmbuild/SRPMS/python-requests-mock-0.5.1-1.fc20.src.rpm [====================================] 100% 00:00:04 33.75 KiB 8.36 KiB/sec Created task: 7481327 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7481327 Watching tasks (this may be safely interrupted)... 7481327 build (rawhide, python-requests-mock-0.5.1-1.fc20.src.rpm): open (buildvm-13.phx2.fedoraproject.org) 7481328 buildArch (python-requests-mock-0.5.1-1.fc20.src.rpm, noarch): open (buildvm-22.phx2.fedoraproject.org) 7481328 buildArch (python-requests-mock-0.5.1-1.fc20.src.rpm, noarch): open (buildvm-22.phx2.fedoraproject.org) -> closed 0 free 1 open 1 done 0 failed 7481327 build (rawhide, python-requests-mock-0.5.1-1.fc20.src.rpm): open (buildvm-13.phx2.fedoraproject.org) -> closed 0 free 0 open 2 done 0 failed 7481327 build (rawhide, python-requests-mock-0.5.1-1.fc20.src.rpm) completed successfully
Human review upcoming, meanwhile, `fedora-review` tool output for the record: `fedora-review` results ======================= Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 4 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/python-requests-mock/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -requests-mock [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-requests-mock-0.5.1-1.fc22.noarch.rpm python3-requests-mock-0.5.1-1.fc22.noarch.rpm python-requests-mock-0.5.1-1.fc22.src.rpm python-requests-mock.noarch: E: explicit-lib-dependency python-urllib3 python-requests-mock.noarch: E: description-line-too-long C requests-mock provides a simple way to do HTTP mocking at the python-requests layer. python3-requests-mock.noarch: E: explicit-lib-dependency python3-urllib3 python3-requests-mock.noarch: E: description-line-too-long C requests-mock provides a simple way to do HTTP mocking at the python-requests layer. python-requests-mock.src: E: description-line-too-long C requests-mock provides a simple way to do HTTP mocking at the python-requests layer. 3 packages and 0 specfiles checked; 5 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-requests-mock python3-requests-mock python-requests-mock.noarch: E: explicit-lib-dependency python-urllib3 python-requests-mock.noarch: E: description-line-too-long C requests-mock provides a simple way to do HTTP mocking at the python-requests layer. python3-requests-mock.noarch: E: explicit-lib-dependency python3-urllib3 python3-requests-mock.noarch: E: description-line-too-long C requests-mock provides a simple way to do HTTP mocking at the python-requests layer. 2 packages and 0 specfiles checked; 4 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- python-requests-mock (rpmlib, GLIBC filtered): python(abi) python-requests python-six python-urllib3 python3-requests-mock (rpmlib, GLIBC filtered): python(abi) python3-requests python3-six python3-urllib3 Provides -------- python-requests-mock: python-requests-mock python3-requests-mock: python3-requests-mock Source checksums ---------------- https://pypi.python.org/packages/source/r/requests-mock/requests-mock-0.5.1.tar.gz : CHECKSUM(SHA256) this package : b1b1b864e633418c77f33d333b0fd88cb6123bfb816706b236f7b1db99795056 CHECKSUM(SHA256) upstream package : b1b1b864e633418c77f33d333b0fd88cb6123bfb816706b236f7b1db99795056
Output of licensecheck.txt: $ cat licensecheck.txt *No copyright* Apache (v2.0) ---------------------------- requests-mock-0.5.1/%{py3dir}/requests_mock/__init__.py requests-mock-0.5.1/%{py3dir}/requests_mock/adapter.py requests-mock-0.5.1/%{py3dir}/requests_mock/compat.py requests-mock-0.5.1/%{py3dir}/requests_mock/contrib/fixture.py requests-mock-0.5.1/%{py3dir}/requests_mock/exceptions.py requests-mock-0.5.1/%{py3dir}/requests_mock/mocker.py requests-mock-0.5.1/%{py3dir}/requests_mock/response.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/base.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/test_adapter.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/test_custom_matchers.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/test_fixture.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/test_matcher.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/test_mocker.py requests-mock-0.5.1/%{py3dir}/requests_mock/tests/test_response.py requests-mock-0.5.1/requests_mock/__init__.py requests-mock-0.5.1/requests_mock/adapter.py requests-mock-0.5.1/requests_mock/compat.py requests-mock-0.5.1/requests_mock/contrib/fixture.py requests-mock-0.5.1/requests_mock/exceptions.py requests-mock-0.5.1/requests_mock/mocker.py requests-mock-0.5.1/requests_mock/response.py requests-mock-0.5.1/requests_mock/tests/base.py requests-mock-0.5.1/requests_mock/tests/test_adapter.py requests-mock-0.5.1/requests_mock/tests/test_custom_matchers.py requests-mock-0.5.1/requests_mock/tests/test_fixture.py requests-mock-0.5.1/requests_mock/tests/test_matcher.py requests-mock-0.5.1/requests_mock/tests/test_mocker.py requests-mock-0.5.1/requests_mock/tests/test_response.py Unknown or generated -------------------- requests-mock-0.5.1/%{py3dir}/docs/conf.py requests-mock-0.5.1/%{py3dir}/setup.py requests-mock-0.5.1/docs/conf.py requests-mock-0.5.1/setup.py
So, I think we need a V2 of SPEC (don't forget to bump up the Release), and its corresponding new SRPM. Comments: (1) Please wrap the description text to 72 characters (2) Remove the egg info in %prep, something like: # Remove bundled egg-info rm -rf %{pypi_name}.egg-info (3) You can remove CFLAGS="$RPM_OPT_FLAGS" from %build section. It's not needed for noarch packages. (4) About the "*No copyright* Apache (v2.0)": - (C) notice is not required, everything is (C) by default http://en.wikipedia.org/wiki/Copyright#Copyright_notices_in_the_United_States - And, all the said files have licesnse text in it. So, no action needed here. (5) Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 - Standard directories, so this is fine. No action needed here.
* Wrapped Description * Removed CFLAGS * Removed Bundled egg-info prior to building SPEC: https://fedorapeople.org/~jamielennox/python-requests-mock.spec SRPM: https://fedorapeople.org/~jamielennox/python-requests-mock-0.5.1-2.fc20.src.rpm scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7507104 Thanks!
Summary: Looks good; approved. (Jamie addressed the issues from comment #4.) Rest of human review -------------------- ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. * ASL 2.0 [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache (v2.0)". 4 files have unknown license. Detailed output of licensecheck in /home/kashyap/rpmbuild/SRPMS/python-requests-mock/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 - Standard directories, this is fine. [-]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 * Standard directories, so this is fine [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. * No -doc subpackage is necessary [x]: Package complies to the Packaging Guidelines Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. egg-info for the package: ---- $ tree ./rpms-unpacked/python3-requests-mock-0.5.1-1.fc22.noarch.rpm/usr/lib/python3.4/site-packages/requests_mock-0.5.1-py3.4.egg-info/ ./rpms-unpacked/python3-requests-mock-0.5.1-1.fc22.noarch.rpm/usr/lib/python3.4/site-packages/requests_mock-0.5.1-py3.4.egg-info/ ├── dependency_links.txt ├── not-zip-safe ├── PKG-INFO ├── requires.txt ├── SOURCES.txt └── top_level.txt ---- [x]: Package meets the Packaging Guidelines::Python ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -requests-mock [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. * noarch package [x]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. Rpmlint is happy too: $ rpmlint python-requests-mock.spec ../SRPMS/python-requests-mock-0.5.1-2.fc20.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
New Package SCM Request ======================= Package Name: python-requests-mock Short Description: A requests mocking tool for python Upstream URL: http://requests-mock.readthedocs.org/ Owners: jamielennox Branches: f19 f20 f21 el6 epel7 InitialCC:
Git done (by process-git-requests).
python-requests-mock-0.5.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-requests-mock-0.5.1-2.fc20
python-requests-mock-0.5.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-requests-mock-0.5.1-2.fc21
python-requests-mock-0.5.1-2.fc21 has been pushed to the Fedora 21 testing repository.
python-requests-mock-0.5.1-2.fc20 has been pushed to the Fedora 20 stable repository.
python-requests-mock-0.5.1-2.fc21 has been pushed to the Fedora 21 stable repository.