Bug 1134773 - cli-rpc-ops.c fails to compile with -Werror=format-security
Summary: cli-rpc-ops.c fails to compile with -Werror=format-security
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: mainline
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
Assignee: Niels de Vos
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-08-28 08:56 UTC by Niels de Vos
Modified: 2015-05-14 17:43 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:27:25 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Niels de Vos 2014-08-28 08:56:50 UTC
Description of problem:

Nightly builds on Fedora Rawhide (x86_64 and i686) started to fail with the
following error:

  cli-rpc-ops.c: In function 'gf_cli_get_vol_opt_cbk':
  cli-rpc-ops.c:9339:25: error: format not a string literal and no format arguments [-Werror=format-security]
                           cli_err (msg);
                           ^


Version-Release number of selected component (if applicable):
Yesterday and current master branch

How reproducible:
100%

Steps to Reproduce:
1. compile with gcc and use -Werror=format-security

Actual results:
build fails

Expected results:
build should succeed

Additional info:

Comment 1 Anand Avati 2014-08-28 08:57:47 UTC
REVIEW: http://review.gluster.org/8560 (build: fixes for compiling with -Werror=format-security) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-08-29 17:01:54 UTC
COMMIT: http://review.gluster.org/8560 committed in master by Vijay Bellur (vbellur) 
------
commit 370592cd702a2c135ba4accfcbe9e1a63c3b6166
Author: Niels de Vos <ndevos>
Date:   Thu Aug 28 10:46:50 2014 +0200

    build: fixes for compiling with -Werror=format-security
    
    Nightly builds on Fedora Rawhide (x86_64 and i686) started to fail with the
    following error:
    
      cli-rpc-ops.c: In function 'gf_cli_get_vol_opt_cbk':
      cli-rpc-ops.c:9339:25: error: format not a string literal and no format arguments [-Werror=format-security]
                               cli_err (msg);
                               ^
    
    The cli_err() should be called with a format-string like "%s" to prevent
    unexpected errors.
    
    Change-Id: I6a287795fb8b7a305c8f14323456eeabf68d100c
    BUG: 1134773
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8560
    Reviewed-by: Harshavardhana <harsha>
    Reviewed-by: Atin Mukherjee <amukherj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

Comment 3 Niels de Vos 2015-05-14 17:27:25 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:34 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:37:56 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:43:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.