When building in mock environment vdsm.spec does't have a BuildRequires: sudo and some of the tests then do not check for sudo availability correctly Let's make sure we can build a proper rpm even without sudo...
What are the steps to reproduce? Would be building from SRPM sufficient?
build vdsm with "sudo" missing. see that the checks either succeed or are skipped.
Sorry, but you haven't answered my question. Is building form SRPM enough or do I have to build from git?
Well, it depends if your srpm has the %check section commented out (for a proper verification, it should be enabled). ./autogen --system && ./configure && make check As a normal user, with sudo missing, would be best.
something is broken in pyflakes target ...snip... config.status: creating tests/run_tests.sh config.status: creating tests/run_tests_local.sh config.status: executing depfiles commands config.status: executing default commands Checking that .in files are ignored... python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)' pyflakes-0.4.0 find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs /usr/bin/pyflakes | \ grep -w -v "\./vdsm/storage/lvm\.py.*: list comprehension redefines 'lv' from line .*" | \ while read LINE; do echo "$LINE"; false; done ./lib/vdsm/ipwrapper.py:253: redefinition of function 'promisc' from line 249 make: *** [pyflakes] Error 1
Toni, could you fix pyflakes on el6? Jiri, the glitch that you report exists only on the master branch. This is a 3.4.4 bug, which should be verified against 3.4.z code.
This is a bug in the old pyflakes. I'll be able to bypass it by uglying a bit the code.
ok, i got these... latest commit into testValidation.py - ec6c309683c5c6addf1df5ad6d53f67ebdcfc4c9 test_mkIsoFs(label='fslabel') SKIP: Test requires SUDO executable ([Errno 2] No such file or directory) test_mkIsoFs(label=None) SKIP: Test requires SUDO executable ([Errno 2] No such file or directory) test_removeFs SKIP: Test requires SUDO executable ([Errno 2] No such file or directory) testLoopMount SKIP: Test requires SUDO executable ([Errno 2] No such file or directory)
oVirt 3.4.4 has been released.