Spec URL: https://kc8hfi.fedorapeople.org/perl-MIME-Lite-TT-HTML.spec SRPM URL: https://kc8hfi.fedorapeople.org/perl-MIME-Lite-TT-HTML-0.04-1.fc20.src.rpm Description: This module provide easy interface to make MIME::Lite object with html formatted mail. Fedora Account System Username: kc8hfi
Hi Charles, are you planning to build for EPEL5?
I hadn't planned on it, but I reckon I could.
Okay. Your spec file has a lot of lines in it that are only useful for EPEL5. Specifically, BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) rm -rf $RPM_BUILD_ROOT %clean rm -rf $RPM_BUILD_ROOT %defattr(-,root,root,-) You can either remove these lines and not build for EPEL5 (but can still build for EPEL6 and EPEL7) or you have to get a SRPM that builds successfully in EPEL5. An example build is shown below http://koji.fedoraproject.org/koji/taskinfo?taskID=7493527 This build was triggered by me executing $ koji build --scratch el5-candidate ~/perl-MIME-Lite-TT-HTML-0.04-1.fc20.src.rpm which is a really good way of checking that your build works as expected. It looks like the EPEL5 build failed due to EPEL5 not being able to cope with modern digests. I've never wanted to do a EPEL5 build, so i can't help you with how to get this to work. If you decide not to do a EPEL5 build, i'm happy to review the package. Otherwise, you can wait for someone else who is more experienced with EPEL5 to help you prepare the package for EPEL5.
I decided not to build for epel5. I removed those items from the spec file and have updated them. They are at the same links in the Description.
okay, i'll take this one
license is correct. package builds successfully in rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=7512906 epel6 builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7512933 rpmlint is clean TODO: If you sort your BuildRequires, it is a lot easier for reviewers. FIX: Missing BuildRequires. All modules loaded while building and testing this module should be included. They are listed below; BR: perl(Carp) BR: perl(Encode) BR: perl(strict) BR: perl(Test::More) MUST FIX: The test suite must be enabled. TODO: I would recommend you use the Module::Build option for building this module. The author provides a Makefile.PL, but it is just a wrapper around Module::Build. MUST FIX: "BuildRequires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))" is incorrect. This is a Run Time requirement, use a "Requires" instead of a "BuildRequires" TODO: PERL_INSTALL_ROOT should be changed to DESTDIR
I added those buildrequires and sorted them alphabetically. The test suite should now be enabled. Made perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version a Requires, and changed PERL_INSTALL_ROOT to DESTDIR. The new files are in the links in the Description.
Okay. Looking good. Last things. Add the LICENSE file to %doc Remove the "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} ';' 2>/dev/null" line. It is intended to fix a very old bug and is no longer required. Replace the "chmod -R u+w $RPM_BUILD_ROOT/*" line with "%{_fixperms} $RPM_BUILD_ROOT/*".
Ok, made those few changes. New files are at the link in the Description
Ack. Builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7534792 Package APPROVED
New Package SCM Request ======================= Package Name: perl-MIME-Lite-TT-HTML Short Description: Create html mail with MIME::Lite and TT Upstream URL: http://search.cpan.org/~chunzi/MIME-Lite-TT-HTML-0.04/ Owners: kc8hfi Branches: f19 f20 InitialCC: perl-sig
Git done (by process-git-requests). Added f21.
perl-MIME-Lite-TT-HTML-0.04-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-MIME-Lite-TT-HTML-0.04-1.fc20
perl-MIME-Lite-TT-HTML-0.04-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-MIME-Lite-TT-HTML-0.04-1.fc19
perl-MIME-Lite-TT-HTML-0.04-1.fc20 has been pushed to the Fedora 20 testing repository.
perl-MIME-Lite-TT-HTML-0.04-1.fc20 has been pushed to the Fedora 20 stable repository.