Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kinfocenter.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kinfocenter-5.0.1-1.fc20.src.rpm Description: KDE Info Center. Fedora Account System Username: dvratil
1) Some files are also under LGPLv2+ 2) Missing provides for obsoleted kde-workspace, but this will be solved in future 3) Missing %config in front of /etc/xdg/menus/kinfocenter.menu
Spec URL: https://dvratil.fedorapeople.org/plasma5/review/kinfocenter.spec SRPM URL: https://dvratil.fedorapeople.org/plasma5/review/kinfocenter-5.1.2-2.fc21.src.rpm - fixed license - fixed missing %config Obsoletes/conflict with kde-workspace is not desired. Instead, kinfocenter subpackage should be created in kde-workspace to ensure smooth upgrade path.
ping, awaiting feedback from reviewer.
Looks good now, package approved.
New Package SCM Request ======================= Package Name: kinfocenter Short Description: KDE Info Center Upstream URL: https://projects.kde.org/projects/kde/workspace/kinfocenter Owners: group::kde-sig Branches: InitialCC:
Spotted 2 more issues, both are not blockers and could be fixed during import: - url should be https://projects.kde.org/projects/kde/workspace/kinfocenter - use make install make install/fast DESTDIR=%{buildroot} -C %{_target_platform} instead of %make_install ...
All fixed locally, also added --with-kde to %find_lang to extract localized docs
Git done (by process-git-requests).