Bug 1135771 - [engine-backend] Moving a shared disk to a gluster domain is not blocked
Summary: [engine-backend] Moving a shared disk to a gluster domain is not blocked
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-core
Version: 3.5
Hardware: x86_64
OS: Unspecified
unspecified
high
Target Milestone: ---
: 3.5.2
Assignee: Amit Aviram
QA Contact: Elad
URL:
Whiteboard: storage
Depends On:
Blocks: 1193058 1196662 1197441
TreeView+ depends on / blocked
 
Reported: 2014-08-31 11:53 UTC by Elad
Modified: 2016-02-10 19:17 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-04-29 06:17:56 UTC
oVirt Team: Storage
Embargoed:

Attachments (Terms of Use)
engine.log (543.38 KB, application/octet-stream)
2014-08-31 11:53 UTC, Elad 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 35398 0 master MERGED core: Preventing moving a shareable disk to a Gluster domain 2020-09-10 12:51:10 UTC
oVirt gerrit 36359 0 master MERGED webadmin: Preventing moving a shareable disk to a Gluster domain 2020-09-10 12:51:10 UTC
oVirt gerrit 37278 0 ovirt-engine-3.5 MERGED webadmin: Preventing moving a shareable disk to a Gluster domain 2020-09-10 12:51:09 UTC

Description Elad 2014-08-31 11:53:27 UTC 
Created attachment 933119 [details]
engine.log

Description of problem:
I was able to move a disk to a Gluster domain. This operation should be blocked since shared disk on Gluster domain is not supported. 

Version-Release number of selected component (if applicable):
ovirt-3.5 RC1.1
ovirt-engine-3.5.0-0.0.master.20140821064931.gitb794d66.el6.noarch

How reproducible:
Always

Steps to Reproduce:
On a shared DC, have NFS and Gluster domains:
1. Create a disk on the NFS domain. Mark it as shareable
2. Move the disk to the Gluster domain


Actual results:
Shared disk movement to the Gluster domain is not blocked. After the movement, I was able to attach the disk to 2 VMs


2014-08-31 14:50:08,870 INFO  [org.ovirt.engine.core.vdsbroker.irsbroker.MoveImageGroupVDSCommand] (org.ovirt.thread.pool-8-thread-12) [7f0cbe36] START, MoveImageGroupVDSCommand( storagePoolId = 00000002-0002-0002-0002-000000000267, ignoreFailoverLimit = false, storageDomainId = e0d4bbba-bc16-45fb-a6e1-2b148a14149f, imageGroupId = e22cfd4b-c2b9-47fc-8a13-65c365855341, dstDomainId = ccf133e6-3710-40a6-9ebb-031ed5ca15af, vmId = 00000000-0000-0000-0000-000000000000, op = Copy, postZero = false, force = false), log id: 4be0b381


Expected results:
Since we have don't allow creation of shared disks on Gluster domain, moving shared disks to Gluster should be blocked too. 
 

Additional info: engine.log
Comment 1 Elad 2014-08-31 15:28:58 UTC 
Description of problem:
I was able to move a shared disk to a Gluster domain. This operation should be blocked since shared disk on Gluster domain is not supported.
Comment 2 Allon Mureinik 2014-09-01 15:17:01 UTC 
Should be considered in cold move, live storage migration, clone vm from snapshot/template and import
Comment 3 Elad 2014-09-04 12:10:30 UTC 
The operation of live migrating a shared disk is already blocked.
For clone VM from snapshot/template it's not relevant since the shared disk is not included in the template/snapshot anyway, also for import.
Comment 4 Allon Mureinik 2014-09-04 12:24:14 UTC 
Elad - true, true and true.
Just disregard my comment #2.
Comment 5 Allon Mureinik 2014-12-30 21:00:18 UTC 
Returning to POST - the frontend patch isn't merged yet.
Comment 6 Allon Mureinik 2015-01-26 11:06:02 UTC 
Why is this bug on MODIFIED?
http://gerrit.ovirt.org/#/c/37278/ isn't merged yet.
Comment 7 Amit Aviram 2015-01-27 10:14:58 UTC 
It is merged now.
Comment 8 Eyal Edri 2015-02-26 12:32:34 UTC 
this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.
Comment 9 Elad 2015-03-18 09:15:49 UTC 
Shared disks cannot be moved to a Gluster domain.

Tested using rhev 3.5.1 vt14
Comment 10 Eyal Edri 2015-04-29 06:17:56 UTC 
ovirt 3.5.2 was GA'd. closing current release.
Note You need to log in before you can comment on or make changes to this bug.