Spec URL: https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-mocks.spec SRPM URL: https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-mocks-2.14.6-2.fc22.src.rpm Description: rspec-mocks provides a test-double framework for rspec including support for method stubs, fakes, and message expectations. Fedora Account System Username: mtasaka
Note that to this package needs bootstap to enable test suite (see %need_bootstrap_set)
I will take it for a review.
1, Fix spelling: "Rspec-2 doubles (mocks and stubs)" should be "RSpec 2 doubles (mocks and stubs)" "rspec-mocks provides a test-double framework for rspec including support for method stubs, fakes, and message expectations." should be "rspec-mocks provides a test-double framework for RSpec including support for method stubs, fakes, and message expectations." 2, Why do you need two macros for bootstrapping? Isn't need_bootstrap enough? 3, Use single spaces rather than tabs: "%doc %{gem_instdir}/*.md" should be rather "%doc %{gem_instdir}/*.md" This is my personal opinion; using tabs looks like it's badly formatted.
Thank you for comments. I will leave "tab v.s. space" preference as before. https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-mocks-2.14.6-3.fc.src.rpm https://mtasaka.fedorapeople.org/Review_request/rspec2/rubygem-rspec2-mocks.spec * Wed Sep 17 2014 Mamoru TASAKA <mtasaka> - 2.14.6-3 - Modify summary, description a bit - Kill redundant macro - Fix BR to use rspec2, not rspec
The package looks good now ==> APPROVED.
Sorry for LOOOOONG delay. Thank you for review. New Package SCM Request ======================= Package Name: rubygem-rspec2-mocks Short Description: Rspec 2 doubles (mocks and stubs) Upstream URL: http://github.com/rspec/rspec-mocks Owners: mtasaka Branches: InitialCC:
Git done (by process-git-requests).
Imported, closing. Thank you for review and git procedure.