Description of problem: When used as the desktop containment, FolderView displays a scrollbar and no icons, even if there are items in the displayed folder, on login https://bugs.kde.org/show_bug.cgi?id=294795 There is a workaround patch available that fixes the problem. This patch should be included, without it KDE desktop is unusable in folder view. Patch is available at: https://bugsfiles.kde.org/attachment.cgi?id=88446 Version-Release number of selected component (if applicable): kde-baseapps 4.13.3-1 How reproducible: not always but often Steps to Reproduce: 1. install KDE desktop 2. select FolderView for desktop 3. login/reboot few times 4. sometimes desktop icon are missing Actual results: sometimes desktop icon are missing when using folder view Expected results: icons should be always present ;) Additional info: https://bugs.kde.org/show_bug.cgi?id=294795
I'd be hesitant to include any patch without upstream comment or review. That said, it appears to be quite small: --- a/plasma/applets/folderview/folderview.cpp 2014-08-13 06:58:14.000000000 +0100 +++ b/plasma/applets/folderview/folderview.cpp 2014-08-26 22:50:58.785527385 +0100 @@ -1357,6 +1357,13 @@ if (c->metaObject()->indexOfSlot("availableScreenRect(int)") != -1) { QMetaObject::invokeMethod(c, "availableScreenRect", Qt::DirectConnection, Q_RETURN_ARG(QRect, availRect), Q_ARG(int, screen())); + + // Workaround for bug 294795. Some kind of memory corruption error leads to + // availRect.bottom() being set to 0 after availableScreenRect returns. + // If this happens, use qdesktopwidget instead. + if (availRect.bottom() == 0) { + availRect = QApplication::desktop()->availableGeometry(screen()); + } } else { kDebug() << "using qdesktopwidget"; availRect = QApplication::desktop()->availableGeometry(screen());
There's quite interesting debate going on at git review board: https://git.reviewboard.kde.org/r/120057/
I would characterize it as "thorough and thoughtful review", which is precisely the purpose of using a tool like reviewboard. :)
And, given that upstream has now given it's blessing/ShipIt!, I'll make sure this fix is included in the next batch of updates released (likely to be included when kde-4.14.1 lands soon).
Fix was included here, * Thu Sep 25 2014 Rex Dieter <rdieter> - 4.14.1-2 - pull in upstream fixes, particularly... - Fix scrollbar appearing on FolderView (kde#294795) and, F-21: https://admin.fedoraproject.org/updates/FEDORA-2014-11603/kde-baseapps-4.14.1-2.fc21 F-20: https://admin.fedoraproject.org/updates/FEDORA-2014-11448