Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1136825

Summary:	Metadata sync in self-heal is not happening inside metadata locks
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.6.0	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.0beta1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1132461	Environment:
Last Closed:	2014-11-11 08:37:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1132461
Bug Blocks:

Description Pranith Kumar K 2014-09-03 11:56:49 UTC

+++ This bug was initially created as a clone of Bug #1132461 +++

Description of problem:
While reading code I observed that metadata sync is happening outside metadata locks, this can lead to inconsistencies if new metadata operations are happening at the same time.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-08-22 04:00:47 EDT ---

REVIEW: http://review.gluster.org/8514 (cluster/afr: Perform metadata sync inside metadata locks) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2014-08-22 05:33:22 EDT ---

COMMIT: http://review.gluster.org/8514 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit bc38d564663a64072ca508da12a8b4b6d48995e9
Author: Pranith Kumar K <pkarampu>
Date:   Thu Aug 21 17:30:10 2014 +0530

    cluster/afr: Perform metadata sync inside metadata locks
    
    Change-Id: Ie55b3d37cacbdad74a3f63c3b0f025b0ffd0104a
    BUG: 1132461
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8514
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krutika Dhananjay <kdhananj>

Comment 1 Anand Avati 2014-09-03 12:03:28 UTC

REVIEW: http://review.gluster.org/8590 (cluster/afr: Perform metadata sync inside metadata locks) posted (#1) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2014-09-12 08:46:10 UTC

COMMIT: http://review.gluster.org/8590 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit ab42176d73a31544accd4981d656a8cee933646c
Author: Pranith Kumar K <pkarampu>
Date:   Thu Aug 21 17:30:10 2014 +0530

    cluster/afr: Perform metadata sync inside metadata locks
    
            Backport of http://review.gluster.org/8514
    
    BUG: 1136825
    Change-Id: I480a0dc0dfff8bcff084c9b3f048c5b355683f73
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8590
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-09-22 12:45:22 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 4 Niels de Vos 2014-11-11 08:37:43 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users