Bug 113759 - emacs compile warnings in coding.c and eval.c
emacs compile warnings in coding.c and eval.c
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: emacs (Show other bugs)
1
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jens Petersen
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2004-01-17 06:36 EST by d.binderman
Modified: 2007-11-30 17:10 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-04-15 22:09:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description d.binderman 2004-01-17 06:36:55 EST
Description of problem:

I just tried to compile package emacs-21.3-7, from Redhat
Fedora Core 1.

The compiler said

coding.c(4077): warning #165: too few arguments in function call

The source code is

          mask |= detect_coding_iso2022 (src, src_end);

but, earlier in the same file is the source code

static int
detect_coding_iso2022 (src, src_end, multibytep)
     unsigned char *src, *src_end;
     int multibytep;
{

Suggest that the call at line 4077 is missing a parameter.

Suggest also use ISO C prototypes, whch have been around about fifteen
years now. Isn't it time to upgrade ?

2.

eval.c(1192): remark #592: variable "h" is used before its value is set

The source code is

      if (!NILP (h.var))

Suggest init h before first use.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Jens Petersen 2004-01-21 03:34:47 EST
Which compiler are you using btw?
Comment 2 d.binderman 2004-01-21 05:06:31 EST
>Which compiler are you using btw?

Intel 8.0

It has two advantages over GNU

1. More & better warning messages (see above)

2. Better code generation.
Comment 3 Jens Petersen 2004-04-15 09:46:00 EDT
(1) detect_coding_iso2022 has been fixed in cvs it appears.

(2) appears unchanged in cvs: I suggest reporting it upstream,
eg on emacs-devel list.
Comment 4 Jens Petersen 2004-04-15 22:09:34 EDT
For (2) I got a response on emacs-devel from Andrea Schwab:

"This is bogus, the compiler apparently does not grok _setjmp."

Note You need to log in before you can comment on or make changes to this bug.