Bug 1138115 - [ImportDomain] The attach operation should issue a warning, if the Storage Domain is already attached to another Data Center in another setup
Summary: [ImportDomain] The attach operation should issue a warning, if the Storage Do...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-3.6.0-rc
: 3.6.0
Assignee: Maor
QA Contact: lkuchlan
URL:
Whiteboard:
Depends On:
Blocks: 1176552
TreeView+ depends on / blocked
 
Reported: 2014-09-04 06:18 UTC by Maor
Modified: 2016-03-10 12:03 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Previously, when a user attached a storage domain that was already in use and managed by a different Manager, no warning was provided, and the action lead to potential metadata corruption. With this update, users are notified with a warning message that the intended storage domain is already attached to another data center managed in another Red Hat Enterprise Virtualization environment. The user can choose to continue and overwrite the metadata or to cancel the action.
Clone Of:
: 1176552 (view as bug list)
Environment:
Last Closed:
oVirt Team: Storage
Target Upstream Version:
Embargoed:
amureini: Triaged+


Attachments (Terms of Use)
image (40.31 KB, image/jpeg)
2015-05-20 12:27 UTC, lkuchlan
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 36447 0 master MERGED core: Add vdc query for attached Storage Domain 2020-06-06 00:28:15 UTC
oVirt gerrit 36448 0 master MERGED core: Add vdc query for import File Storage Domain 2020-06-06 00:28:15 UTC
oVirt gerrit 36449 0 master MERGED core: Set storagePoolId when fetching Existing Storage Domains. 2020-06-06 00:28:14 UTC
oVirt gerrit 36450 0 master MERGED webadmin: Add query calls to AsyncDataProvider 2020-06-06 00:28:14 UTC
oVirt gerrit 36451 0 master MERGED webadmin: Support warnning for import/attach operation 2020-06-06 00:28:14 UTC
oVirt gerrit 36452 0 master ABANDONED webadmin: Add attach warnning in Data center module 2020-06-06 00:28:14 UTC
oVirt gerrit 36453 0 master ABANDONED webadmin: Add attach/import warnning in Storage module 2020-06-06 00:28:14 UTC
oVirt gerrit 36478 0 master MERGED core: Add vdc query for import Block Storage Domain 2020-06-06 00:28:14 UTC
oVirt gerrit 36540 0 ovirt-engine-3.5 MERGED core: Add vdc query for attached Storage Domain 2020-06-06 00:28:14 UTC
oVirt gerrit 36541 0 ovirt-engine-3.5 MERGED core: Add vdc query for import File Storage Domain 2020-06-06 00:28:14 UTC
oVirt gerrit 36542 0 ovirt-engine-3.5 MERGED core: Add vdc query for import Block Storage Domain 2020-06-06 00:28:14 UTC
oVirt gerrit 36543 0 ovirt-engine-3.5 MERGED core: Set storagePoolId when fetching Existing Storage Domains. 2020-06-06 00:28:14 UTC
oVirt gerrit 36544 0 ovirt-engine-3.5 MERGED webadmin: Add query calls to AsyncDataProvider 2020-06-06 00:28:14 UTC
oVirt gerrit 36545 0 ovirt-engine-3.5 MERGED webadmin: Support warnning for import/attach operation 2020-06-06 00:28:14 UTC

Description Maor 2014-09-04 06:18:13 UTC
Description of problem:
The attach operation should notify the user, a warning, whether the Storage Domain is already attached to another Data Center.
The user can then choose whether to run over the meta data or neglect his operation.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Attach a Storage Domain already attached to another setup
2.
3.

Actual results:
Storage Domain will be attached and run over the former meta data 

Expected results:
We should add a warning indicating that the Storage Domain is already attached to another Data Center

Additional info:

Comment 1 Allon Mureinik 2014-09-04 11:23:40 UTC
Why a warning? Shouldn't we just block it?

Comment 2 Maor 2014-09-10 11:57:40 UTC
because the storage domain might be already attached to another working setup, or it can be part of the DR porocess

Comment 3 Allon Mureinik 2014-11-26 16:02:15 UTC
This is a very risky change, with a limited reward.
Pushing out.

Comment 5 Allon Mureinik 2015-03-31 07:07:45 UTC
Julie, Thanks for the doctext!
However, I think it's missing an important point - this BZ related to a storage domain that is connected to a data center in a *different setup* (i.e., a data center managed by a different engine).
If you attempt to attach a storage domain to a different data center in the same DC, you'll get a different error message, and will not be given the option to forecefully overwrite the metadata - you'd have to properly detach the domain from the data center first.

Comment 6 Kevin Alon Goldblatt 2015-04-29 07:41:57 UTC
Maor,

I seem to be missing something here.

In the steps to reproduce you wrote:
1. Attach a Storage Domain already attached to another setup

When I go to the Data Centre Tab - Press on Attach Data I get a message saying that there are no available Storage domains to attach. No external domains are displayed here

When creating a new storage domain you already attach it to a DC and then these storage domains are not displayed as available

So how do I reproduce this scenario?

Comment 7 Maor 2015-04-29 16:47:51 UTC
You should do the following:
1. Create a new setup with Storage Domain VMs and disks
2. Move the Storage Domain to maintenance
3. Create a new setup with a new DC, new Storage Domain and Host, so the Data Center will be active and initialized
4. import the old storage domain to the setup to the specific DC

 Expected result: You should see a warning when attaching the Storage Domain that it is already attached to a different Data Center

Comment 8 lkuchlan 2015-05-20 12:27:17 UTC
Created attachment 1027704 [details]
image

Tested using ovirt-engine-3.6.0-0.0.master.20150412172306.git55ba764.el6

Verification instructions:
1. Create a new setup with Storage Domain VMs and disks
2. Move the Storage Domain to maintenance
3. Create a new setup with a new DC, new Storage Domain and Host, so the Data Center will be active and initialized
4. import the old storage domain to the setup to the specific DC

Result: warning message should appear: "Storage Domain(s) are already attached to a Data Center. Approving this operation might cause data corruption if both Data Centers are active"

Comment 9 Allon Mureinik 2016-03-10 10:42:04 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 10 Allon Mureinik 2016-03-10 10:46:54 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE

Comment 11 Allon Mureinik 2016-03-10 12:03:28 UTC
RHEV 3.6.0 has been released, setting status to CLOSED CURRENTRELEASE


Note You need to log in before you can comment on or make changes to this bug.