Spec URL: http://anishpatil.fedorapeople.org/nodejs-mustache.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-mustache-0.8.2-1.fc20.src.rpm Description: mustache.js is an implementation of the mustache template system in JavaScript Fedora Account System Username: anishpatil
Review: + Package built successful in mock (f22 x86_64) - rpmlint on generated rpms gave output nodejs-mustache.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-mustache.noarch: W: summary-not-capitalized C mustache.js is an implementation of the mustache template system in JavaScript nodejs-mustache.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-mustache.noarch: W: only-non-binary-in-usr-lib nodejs-mustache.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-mustache.src: W: summary-not-capitalized C mustache.js is an implementation of the mustache template system in JavaScript nodejs-mustache.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 7 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 602be26bb07629b07db996341ca231a831790c972c6ed35e6bfbd51957e096a9 upstream tarball: 602be26bb07629b07db996341ca231a831790c972c6ed35e6bfbd51957e096a9 + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Adjust summary wording to get it started with Capitalized letter. Like "An implementation of the mustache template system in JavaScript". also, Good to add more information in %description as "Mustache is a logic-less template syntax. It can be used for HTML, config files, source code - anything. It works by expanding tags in a template using values provided in a hash or object. We call it "logic-less" because there are no if statements, else clauses, or for loops. Instead there are only tags. Some tags are replaced with a value, some nothing, and others a series of values." 2) I still think conditional test should be executed in %check and not the other way. APPROVED.
Thanks Parag for review
New Package SCM Request ======================= Package Name: nodejs-mustache Short Description: mustache.js is an implementation of the mustache template system for node.js Owners: anishpatil Branches: f20 f21 InitialCC: anishpatil
Git done (by process-git-requests).
nodejs-mustache-0.8.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-mustache-0.8.2-1.fc21
nodejs-mustache-0.8.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-mustache-0.8.2-1.fc20
nodejs-mustache-0.8.2-1.fc21 has been pushed to the Fedora 21 testing repository.
nodejs-mustache-0.8.2-1.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-mustache-0.8.2-1.fc21 has been pushed to the Fedora 21 stable repository.