Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit.spec SRPM URL: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-1.fc20.src.rpm RPM URL: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-1.fc20.noarch.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7526740 Description: Percona Toolkit is a collection of advanced command-line tools used by Percona (http://www.percona.com/) support staff to perform a variety of MySQL and system tasks that are too difficult or complex to perform manually. Fedora Account System Username: fale
Please don't set the flag when you are the submitter.
Sorry for the flag, thanks for your flag fix :)
I could review this on next Monday, in the past I found it useful. Please drop those obsolete macros like defattr.
Thankyou Christopher for reviewing this package :). I've dropped the defattr macro as you pointed out, thankyou :). Spec URL: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit.spec SRPM URL: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-2.fc20.src.rpm RPM URL: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-2.fc20.noarch.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7531737
Installation errors ------------------- INFO: mock.py version 1.1.41 starting... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Mock Version: 1.1.41 INFO: Mock Version: 1.1.41 Start: lock buildroot INFO: installing package(s): /home/cawk/Desktop/percona-toolkit/results/percona-toolkit-2.2.10-2.fc22.noarch.rpm ERROR: Command failed: # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '22', 'install', '/home/cawk/Desktop/percona-toolkit/results/percona-toolkit-2.2.10-2.fc22.noarch.rpm'] Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(AdvisorRules) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Object) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(DiskstatsGroupByDisk) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(NibbleIterator) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Utils) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(DiskstatsGroupByAll) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Meta) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(DiskstatsGroupBySample) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Transformers) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Quoter) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(ReadKeyMini) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Lmo::Types) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Percona::Toolkit) Error: Package: percona-toolkit-2.2.10-2.fc22.noarch (/percona-toolkit-2.2.10-2.fc22.noarch) Requires: perl(Diskstats) You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest
I've created a new version that filters out those problems with rpm filters and I've tested the various tools so I know they work. SPEC: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit.spec SRPM: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-3.fc20.src.rpm RPM: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-3.fc20.noarch.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7642070
Several issues: 1. SRPM: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-3.fc20.src.rpm RPM: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-3.fc20.noarch.rpm Both urls return "Forbidden" - Please fix these files' permissions. 2. > I've created a new version that filters out those problems with rpm filters This goes too far and does not work. What you are doing means to disable automatic tracking of perl modules for everying under %{_bindir}. You need to apply finer grained filters instead. 3. The scripts inside of this package use /usr/bin/env. In Fedora, scripts are supposed to call the interpreter directly.
Created attachment 939896 [details] Patch to address the issues mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1138476#c7
Thanks to Ralf, I've updated the spec. SPEC: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7653124 SRPM: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-4.fc20.src.rpm RPM: https://fale.fedorapeople.org/percona-toolkit/percona-toolkit-2.2.10-4.fc20.noarch.rpm
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted.
This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
Seems like the submitter account is disabled (?) I will be closing this package review if there is no response in a week.
Closing this review request since submitted account is disabled.