Spec URL: https://ndpfsvn.nikhef.nl/ro/mwsec/packaging/fedora/branches/rawhide/xacml.spec SRPM URL: http://software.nikhef.nl/dist/mwsec/rpm/testing/f20/SRPMS/xacml-1.5.0-1.fc20.src.rpm Description: (from the spec file:) This API provides a basic implementation of the SAML 2.0 profile of XACML v2.0, including support for obligations in XACML response messages. It aids in writing XACML clients and servers. More on the specification can be found here: http://docs.oasis-open.org/xacml/3.0/xacml-profile-saml2.0-v2-spec-en.html This package is a prerequisite for some authorisation software I intend to include later, such as SCAS, EES and argus-pep-api-c. For more information about this software, see http://wiki.nikhef.nl/grid/Site_Access_Control. This packaging was done earlier for the EU funded EGEE project; it carries a few historic obsoletes/provides in order to remain backward compatibility with other packages from this era. I've done a self-review of the software and I found no major trespasses (although I'm biased, of course. ;-) ) I will attach the review text. In summary, there are 4 rpmlint warnings which are fairly innocent: Checking: xacml-1.5.0-1.fc22.x86_64.rpm xacml-devel-1.5.0-1.fc22.x86_64.rpm xacml-1.5.0-1.fc22.src.rpm xacml.x86_64: W: name-repeated-in-summary C XACML (This is a false positive; XACML is the name of the standard as well as the package.) xacml-devel.x86_64: W: only-non-binary-in-usr-lib (Seems to occur when devel packages only contain the .so symlink to the full library.) xacml-devel.x86_64: W: no-documentation (Yeah, there is none in the package.) xacml.src: W: name-repeated-in-summary C XACML 3 packages and 0 specfiles checked; 0 errors, 4 warnings. The spec file contains on occurrence of %define where %global should be used, but this is innocent and will be fixed in a future release. The package is aimed at Fedora as well as EPEL5 so we still include BuildRoot. Fedora Account System Username: dennisvd
The self-review text: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "GPL (v2 or later)". Detailed output of licensecheck in /user/dennisvd/fedora-review/xacml/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Buildroot: present for EPEL5 [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present for EPEL5 [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define fixlibtool() sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtoolsed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtoolsed -i -e 's! -shared ! -Wl,--as-needed\\0!g' libtool [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: xacml-1.5.0-1.fc22.x86_64.rpm xacml-devel-1.5.0-1.fc22.x86_64.rpm xacml-1.5.0-1.fc22.src.rpm xacml.x86_64: W: name-repeated-in-summary C XACML xacml-devel.x86_64: W: only-non-binary-in-usr-lib xacml-devel.x86_64: W: no-documentation xacml.src: W: name-repeated-in-summary C XACML 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint xacml-devel xacml xacml-devel.x86_64: W: only-non-binary-in-usr-lib xacml-devel.x86_64: W: no-documentation xacml.x86_64: W: name-repeated-in-summary C XACML 2 packages and 0 specfiles checked; 0 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- xacml-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libxacml.so.0()(64bit) pkgconfig(gsoap++) xacml(x86-64) xacml (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgsoap++.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- xacml-devel: pkgconfig(xacml) saml2-xacml2-c-lib-devel saml2-xacml2-c-lib-devel(x86-64) xacml-devel xacml-devel(x86-64) xacml: libxacml.so.0()(64bit) saml2-xacml2-c-lib saml2-xacml2-c-lib(x86-64) xacml xacml(x86-64) Source checksums ---------------- http://software.nikhef.nl/security/xacml/xacml-1.5.0.tar.gz : CHECKSUM(SHA256) this package : 4997e9d97ce203b0160aeab6a688e0f841e66309fcd01d89d40457bcca3d03e1 CHECKSUM(SHA256) upstream package : 4997e9d97ce203b0160aeab6a688e0f841e66309fcd01d89d40457bcca3d03e1 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -r -n ./xacml-1.5.0-1.fc20.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
I've run a scratch build on Koji with the src.rpm to confirm [x]: Package should compile and build into binary rpms on all supported architectures. Koji build ref: https://koji.fedoraproject.org/koji/taskinfo?taskID=7529348
Obsoletes: saml2-xacml2-c-lib < 1.1.0 Incomplete, should include %release as well (e.g., 1.1.0-1, 1.1.0-999, depends on the case)
Spec URL: https://ndpfsvn.nikhef.nl/ro/mwsec/packaging/fedora/branches/rawhide/xacml.spec SRPM URL: http://software.nikhef.nl/experimental/fedora/xacml-1.5.0-1.fc22.src.rpm Set the two obsoletes to 1.1.0-1.
BTW, CXXFLAGS is substituted by -fPIC only, is it still needed?
Spec URL: http://software.nikhef.nl/experimental/fedora/xacml-1.5.0-2.spec SRPM URL: http://software.nikhef.nl/experimental/fedora/xacml-1.5.0-2.fc20.src.rpm The CXXFLAGS is not needed anymore. Libtool should do this automatically. It's a remnant from the earliest attempt to package when we had to compile gsoap ourselves. It's harmless but I've removed it to have a slightly cleaner spec file.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
We consider the package no longer important for inclusion in Fedora, so the request can be closed.