Description of problem: Error handling for mmap() in gf_changelog_parse_binary() and gf_changelog_parse_ascii() routines, FILE: gf-changelog-process.c, is not correct. mmap() does not return NULL for FAIL case. Instead it returns MAP_FAILED (i.e. (void *) -1). Refer: man page for mmap(). Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
REVIEW: http://review.gluster.org/9130 (changelog: correct mmap() error checking) posted (#1) for review on master by Niels de Vos (ndevos)
COMMIT: http://review.gluster.org/9130 committed in master by Venky Shankar (vshankar) ------ commit cc57d9bee98270e6e961765716d421bf2f0950d3 Author: Niels de Vos <ndevos> Date: Sat Nov 15 23:07:04 2014 +0100 changelog: correct mmap() error checking Upon failure, mmap() returns MAP_FAILED, which is not equal to NULL. This small correction makes sure that the potential error gets caught and handled. BUG: 1138621 Change-Id: I0a88b5187afa7187dcaa8f7d2cb0f9bb775c929d Reported-by: Santosh Pradhan <santosh.pradhan> Signed-off-by: Niels de Vos <ndevos> Reviewed-on: http://review.gluster.org/9130 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Venky Shankar <vshankar> Tested-by: Venky Shankar <vshankar>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user