Spec URL: http://www.fateyev.com/RPMS/Fedora20/testing/perl-Devel-Timer.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-Devel-Timer-0.05-1.fc20.denf.src.rpm Description: Devel::Timer allows developers to accurately time how long a specific piece of code takes to execute. This can be helpful in locating the slowest parts of an existing application. Fedora Account System Username: dfateyev Koji scratch builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=7540454 (Rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=7540456 (EPEL 5) https://koji.fedoraproject.org/koji/taskinfo?taskID=7540458 (EPEL 6) https://koji.fedoraproject.org/koji/taskinfo?taskID=7540460 (EPEL 7)
So, for the build time deps... Your Makefile.PL uses the bundled inc::Module::Install. That means you need to list the dependencies of the bundled distribution, too. In your case that means the following: - Config, inc/Module/Install/Can.pm:5 - Cwd, inc/Module/Install.pm:22 - Fcntl, inc/Module/Install/Makefile.pm:7 - File::Find, inc/Module/Install.pm:23 - inc/Module/Install.pm:24 - ExtUtils::MM_Unix, inc/Module/Install/Metadata.pm:323, inc/Module/Install/Metadata.pm:332 Other missing build time dep, used by the testsuite: - lib, t/my-timer.t:8 You also list a dependency on Carp which is not used or even mentioned anywhere in the tarball. Please, remove it. Nitpick: Perhaps you could change the el5 check in the %install section to be the same as the check around the BuildRoot tag? Or the other way around. Just to be consistent.
Thanks for the review, Petr. Updated spec: http://www.fateyev.com/RPMS/Fedora20/testing/perl-Devel-Timer.spec SRPM: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-Devel-Timer-0.05-2.fc20.denf.src.rpm Koji scratch builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=7792328 (Rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=7792333 (EPEL 7)
Much better :) Approving.
New Package SCM Request ======================= Package Name: perl-Devel-Timer Short Description: Track and report execution time for parts of code Owners: dfateyev Branches: f19 f20 f21 el5 el6 epel7 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Devel-Timer-0.05-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Devel-Timer-0.05-2.fc21
perl-Devel-Timer-0.05-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Devel-Timer-0.05-2.fc20
perl-Devel-Timer-0.05-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Devel-Timer-0.05-2.fc19
perl-Devel-Timer-0.05-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Devel-Timer-0.05-2.el7
perl-Devel-Timer-0.05-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Devel-Timer-0.05-2.el6
perl-Devel-Timer-0.05-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Devel-Timer-0.05-2.el5
perl-Devel-Timer-0.05-2.fc19 has been pushed to the Fedora 19 testing repository.
perl-Devel-Timer-0.05-2.fc19 has been pushed to the Fedora 19 stable repository.
perl-Devel-Timer-0.05-2.fc20 has been pushed to the Fedora 20 stable repository.
perl-Devel-Timer-0.05-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
perl-Devel-Timer-0.05-2.el5 has been pushed to the Fedora EPEL 5 stable repository.