Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Tangerine/perl-Tangerine.spec SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Tangerine/perl-Tangerine-0.02-1.fc20.src.rpm Description: Tangerine statically analyses perl files and reports various information about provided, used (compile-time dependencies) and required (runtime dependencies) modules. Fedora Account System Username: psabata
URL and Source0 are usable. Ok. Source archive is original (SHA-256: 653a6dfb522df944dca8c33d5e0168ac525e640557b8d10e71172c30b19f287f). Ok. Summary verified from README. Ok. Description verified from README. Ok. License verified from LICENSE. Ok. No XS code, noarch BuildArch is Ok. Test::Pod not used. Ok. $ rpmlint perl-Tangerine.spec ../SRPMS/perl-Tangerine-0.02-1.fc22.src.rpm ../RPMS/noarch/perl-Tangerine-0.02-1.fc22.noarch.rpm perl-Tangerine.src: W: spelling-error Summary(en_US) Analyse -> Analyses, Analyst, Analyze perl-Tangerine.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment perl-Tangerine.noarch: W: spelling-error Summary(en_US) Analyse -> Analyses, Analyst, Analyze perl-Tangerine.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Tangerine-0.02-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Sep 8 16:51 /usr/share/doc/perl-Tangerine -rw-r--r-- 1 root root 212 Sep 5 10:55 /usr/share/doc/perl-Tangerine/CONTRIBUTING -rw-r--r-- 1 root root 143 Sep 5 10:55 /usr/share/doc/perl-Tangerine/Changes -rw-r--r-- 1 root root 1079 Sep 5 10:55 /usr/share/doc/perl-Tangerine/LICENSE -rw-r--r-- 1 root root 2282 Sep 5 10:55 /usr/share/doc/perl-Tangerine/README -rw-r--r-- 1 root root 2793 Sep 8 16:51 /usr/share/man/man3/Tangerine.3pm.gz -rw-r--r-- 1 root root 2356 Sep 8 16:51 /usr/share/man/man3/Tangerine::Hook.3pm.gz -rw-r--r-- 1 root root 2522 Sep 8 16:51 /usr/share/man/man3/Tangerine::HookData.3pm.gz -rw-r--r-- 1 root root 2220 Sep 8 16:51 /usr/share/man/man3/Tangerine::Occurence.3pm.gz -rw-r--r-- 1 root root 2121 Sep 8 16:51 /usr/share/man/man3/Tangerine::Utils.3pm.gz -rw-r--r-- 1 root root 2018 Sep 8 16:51 /usr/share/man/man3/Tangerine::hook::if.3pm.gz -rw-r--r-- 1 root root 2044 Sep 8 16:51 /usr/share/man/man3/Tangerine::hook::list.3pm.gz -rw-r--r-- 1 root root 1996 Sep 8 16:51 /usr/share/man/man3/Tangerine::hook::package.3pm.gz -rw-r--r-- 1 root root 2078 Sep 8 16:51 /usr/share/man/man3/Tangerine::hook::prefixedlist.3pm.gz -rw-r--r-- 1 root root 1997 Sep 8 16:51 /usr/share/man/man3/Tangerine::hook::require.3pm.gz -rw-r--r-- 1 root root 2006 Sep 8 16:51 /usr/share/man/man3/Tangerine::hook::use.3pm.gz drwxr-xr-x 2 root root 0 Sep 8 16:51 /usr/share/perl5/vendor_perl/Tangerine -rw-r--r-- 1 root root 4921 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine.pm -rw-r--r-- 1 root root 1184 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/Hook.pm -rw-r--r-- 1 root root 1902 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/HookData.pm -rw-r--r-- 1 root root 936 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/Occurence.pm -rw-r--r-- 1 root root 1641 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/Utils.pm drwxr-xr-x 2 root root 0 Sep 8 16:51 /usr/share/perl5/vendor_perl/Tangerine/hook -rw-r--r-- 1 root root 1482 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/hook/if.pm -rw-r--r-- 1 root root 1546 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/hook/list.pm -rw-r--r-- 1 root root 808 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/hook/package.pm -rw-r--r-- 1 root root 1472 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/hook/prefixedlist.pm -rw-r--r-- 1 root root 834 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/hook/require.pm -rw-r--r-- 1 root root 1065 Sep 5 10:55 /usr/share/perl5/vendor_perl/Tangerine/hook/use.pm File layout and permissions are Ok. TODO: Package the bin/tangerine tool. $ rpm -q --requires -p ../RPMS/noarch/perl-Tangerine-0.02-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl >= 1:5.010 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Exporter) 1 perl(List::MoreUtils) 1 perl(Mo) 1 perl(PPI) 1 perl(strict) 1 perl(Tangerine::Hook) 1 perl(Tangerine::HookData) 1 perl(Tangerine::Occurence) 1 perl(Tangerine::Utils) 1 perl(utf8) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 FIX: Run-require 'perl(Mo::default) (lib/Tangerine.pm:11). $ rpm -q --provides -p ../RPMS/noarch/perl-Tangerine-0.02-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Tangerine) = 0.02 1 perl(Tangerine::Hook) = 0.02 1 perl(Tangerine::hook::if) = 0.02 1 perl(Tangerine::hook::list) = 0.02 1 perl(Tangerine::hook::package) = 0.02 1 perl(Tangerine::hook::prefixedlist) = 0.02 1 perl(Tangerine::hook::require) = 0.02 1 perl(Tangerine::hook::use) = 0.02 1 perl(Tangerine::HookData) = 0.02 1 perl(Tangerine::Occurence) = 0.02 1 perl(Tangerine::Utils) = 0.02 1 perl-Tangerine = 0.02-1.fc22 Binary provides are Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7544113). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide a new spec file. Resolution: Package NOT approved.
Silly mistakes. Thanks for noticing. SPEC URL: https://psabata.fedorapeople.org/pkgs/perl-Tangerine/perl-Tangerine.spec SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Tangerine/perl-Tangerine-0.03-1.fc20.src.rpm
Changes in the spec file: $ diff -u perl-Tangerine.spec{.old,} --- perl-Tangerine.spec.old 2014-09-08 14:54:46.000000000 +0200 +++ perl-Tangerine.spec 2014-09-09 11:15:18.000000000 +0200 @@ -1,5 +1,5 @@ Name: perl-Tangerine -Version: 0.02 +Version: 0.03 Release: 1%{?dist} Summary: Analyse perl files and report module-related information License: MIT @@ -25,6 +25,7 @@ BuildRequires: perl(version) >= 0.77 BuildRequires: perl(warnings) Requires: perl(:MODULE_COMPAT_%(eval "$(perl -V:version)"; echo $version)) +Requires: perl(Mo::default) %description Tangerine statically analyses perl files and reports various information @@ -48,9 +49,14 @@ %files %doc Changes CONTRIBUTING LICENSE README +%{_bindir}/tangerine %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Mon Sep 08 2014 Petr Šabata <contyk> - 0.03-1 +- 0.03 bump +- Install the tangerine script + * Sun Sep 07 2014 Petr Šabata <contyk> 0.02-1 - Initial package Source archive is original (SHA-256: 2c3ef6109234b14ff6aab1097492721224f888d04853a606a65085ca47791799). Ok. There are no significant changes in the sources besides version strings, Makefile.PL, and META.yml. All tests pass. Ok. $ rpmlint perl-Tangerine.spec ../SRPMS/perl-Tangerine-0.03-1.fc22.src.rpm ../RPMS/noarch/perl-Tangerine-0.03-1.fc22.noarch.rpm perl-Tangerine.src: W: spelling-error Summary(en_US) Analyse -> Analyses, Analyst, Analyze perl-Tangerine.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment perl-Tangerine.noarch: W: spelling-error Summary(en_US) Analyse -> Analyses, Analyst, Analyze perl-Tangerine.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment perl-Tangerine.noarch: W: no-manual-page-for-binary tangerine 2 packages and 1 specfiles checked; 0 errors, 5 warnings. rpmlint is Ok. > TODO: Package the bin/tangerine tool. $ rpm -q -lv -p ../RPMS/noarch/perl-Tangerine-0.03-1.fc22.noarch.rpm -rwxr-xr-x 1 root root 5593 Sep 9 13:55 /usr/bin/tangerine drwxr-xr-x 2 root root 0 Sep 9 13:55 /usr/share/doc/perl-Tangerine -rw-r--r-- 1 root root 212 Sep 8 18:27 /usr/share/doc/perl-Tangerine/CONTRIBUTING -rw-r--r-- 1 root root 230 Sep 8 18:27 /usr/share/doc/perl-Tangerine/Changes -rw-r--r-- 1 root root 1079 Sep 8 18:27 /usr/share/doc/perl-Tangerine/LICENSE -rw-r--r-- 1 root root 2282 Sep 8 18:27 /usr/share/doc/perl-Tangerine/README -rw-r--r-- 1 root root 2793 Sep 9 13:55 /usr/share/man/man3/Tangerine.3pm.gz -rw-r--r-- 1 root root 2356 Sep 9 13:55 /usr/share/man/man3/Tangerine::Hook.3pm.gz -rw-r--r-- 1 root root 2522 Sep 9 13:55 /usr/share/man/man3/Tangerine::HookData.3pm.gz -rw-r--r-- 1 root root 2220 Sep 9 13:55 /usr/share/man/man3/Tangerine::Occurence.3pm.gz -rw-r--r-- 1 root root 2121 Sep 9 13:55 /usr/share/man/man3/Tangerine::Utils.3pm.gz -rw-r--r-- 1 root root 2018 Sep 9 13:55 /usr/share/man/man3/Tangerine::hook::if.3pm.gz -rw-r--r-- 1 root root 2044 Sep 9 13:55 /usr/share/man/man3/Tangerine::hook::list.3pm.gz -rw-r--r-- 1 root root 1996 Sep 9 13:55 /usr/share/man/man3/Tangerine::hook::package.3pm.gz -rw-r--r-- 1 root root 2078 Sep 9 13:55 /usr/share/man/man3/Tangerine::hook::prefixedlist.3pm.gz -rw-r--r-- 1 root root 1997 Sep 9 13:55 /usr/share/man/man3/Tangerine::hook::require.3pm.gz -rw-r--r-- 1 root root 2006 Sep 9 13:55 /usr/share/man/man3/Tangerine::hook::use.3pm.gz drwxr-xr-x 2 root root 0 Sep 9 13:55 /usr/share/perl5/vendor_perl/Tangerine -rw-r--r-- 1 root root 4921 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine.pm -rw-r--r-- 1 root root 1184 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/Hook.pm -rw-r--r-- 1 root root 1902 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/HookData.pm -rw-r--r-- 1 root root 936 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/Occurence.pm -rw-r--r-- 1 root root 1641 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/Utils.pm drwxr-xr-x 2 root root 0 Sep 9 13:55 /usr/share/perl5/vendor_perl/Tangerine/hook -rw-r--r-- 1 root root 1482 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/hook/if.pm -rw-r--r-- 1 root root 1546 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/hook/list.pm -rw-r--r-- 1 root root 808 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/hook/package.pm -rw-r--r-- 1 root root 1472 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/hook/prefixedlist.pm -rw-r--r-- 1 root root 834 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/hook/require.pm -rw-r--r-- 1 root root 1065 Sep 8 18:27 /usr/share/perl5/vendor_perl/Tangerine/hook/use.pm File permissions and layout are Ok. > FIX: Run-require 'perl(Mo::default) (lib/Tangerine.pm:11). $ rpm -q --requires -p ../RPMS/noarch/perl-Tangerine-0.03-1.fc22.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 perl >= 1:5.010 1 perl >= 1:5.016 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Exporter) 1 perl(feature) 1 perl(File::Find::Rule) 1 perl(File::Find::Rule::Perl) 1 perl(Getopt::Long) 1 perl(List::MoreUtils) 1 perl(Mo) 1 perl(Mo::default) 1 perl(PPI) 1 perl(strict) 1 perl(Tangerine) 1 perl(Tangerine::Hook) 1 perl(Tangerine::HookData) 1 perl(Tangerine::Occurence) 1 perl(Tangerine::Utils) 1 perl(utf8) 1 perl(version) >= 0.77 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Tangerine-0.03-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Tangerine) = 0.03 1 perl(Tangerine::Hook) = 0.03 1 perl(Tangerine::hook::if) = 0.03 1 perl(Tangerine::hook::list) = 0.03 1 perl(Tangerine::hook::package) = 0.03 1 perl(Tangerine::hook::prefixedlist) = 0.03 1 perl(Tangerine::hook::require) = 0.03 1 perl(Tangerine::hook::use) = 0.03 1 perl(Tangerine::HookData) = 0.03 1 perl(Tangerine::Occurence) = 0.03 1 perl(Tangerine::Utils) = 0.03 1 perl-Tangerine = 0.03-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Tangerine-0.03-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7555489). Ok. Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Tangerine Short Description: Analyse perl files and report module-related information Upstream URL: http://search.cpan.org/dist/Tangerine Owners: psabata jplesnik ppisar Branches: f20 f21 InitialCC: perl-sig
Git done (by process-git-requests).
perl-Tangerine-0.03-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Tangerine-0.03-1.fc21
perl-Tangerine-0.03-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Tangerine-0.03-1.fc20
perl-Tangerine-0.03-1.fc21 has been pushed to the Fedora 21 stable repository.
perl-Tangerine-0.03-1.fc20 has been pushed to the Fedora 20 stable repository.
Package Change Request ====================== Package Name: perl-Tangerine New Branches: epel7 Owners: psabata InitialCC: perl-sig
perl-Tangerine-0.10-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/perl-Tangerine-0.10-1.el7
perl-Tangerine-0.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
Package Change Request ====================== Package Name: perl-Tangerine New Branches: el6 Owners: psabata InitialCC: perl-sig
Thanks once again.
perl-Tangerine-0.11-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Tangerine-0.11-1.el6
perl-Tangerine-0.11-1.el6 has been pushed to the Fedora EPEL 6 stable repository.