Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1139249

Summary: Bullets are missing from list of warnings presented to user in cases such as when removing a shared disk
Product: [oVirt] ovirt-engine Reporter: lkuchlan <lkuchlan>
Component: Frontend.WebAdminAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Natalie Gavrielov <ngavrilo>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: amureini, bugs, ecohen, gklein, mgoldboi, rbalakri, tnisan, yeylon, ylavi
Target Milestone: ovirt-3.6.1Keywords: UserExperience
Target Release: 3.6.1Flags: ylavi: ovirt-3.6.z?
ylavi: planning_ack?
rule-engine: devel_ack+
ylavi: testing_ack?
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-16 12:23:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Bullets are missing
none
improvement suggestion
none
snapshot after the fix none

Description lkuchlan 2014-09-08 13:14:58 UTC
Created attachment 935341 [details]
Bullets are missing

Description of problem:
Bullets are missing from list of warnings presented to user in cases such as when removing a shared disk

Version-Release number of selected component (if applicable):
3.5

How reproducible:
100%

Steps to Reproduce:
1. Click on the remove button for shared disk

Actual results:
List of warnings without bullets are presented 

Expected results:
List of warnings should have bullets

Comment 1 Allon Mureinik 2014-09-09 21:26:06 UTC
Einav, can you ack/nack this request (wrt to proper web UX, not effort required to do this)

Comment 2 Einav Cohen 2014-09-10 21:06:58 UTC
Created attachment 936325 [details]
improvement suggestion

Comment 3 Einav Cohen 2014-09-10 21:09:14 UTC
(In reply to Allon Mureinik from comment #1)
> Einav, can you ack/nack this request (wrt to proper web UX, not effort
> required to do this)

this request makes sense, see attachment 936325 [details]: for better readability, I think that adding a small indentation to the "Note that the disk is:..." message and bullets to the reasons is a good idea.

Comment 4 Allon Mureinik 2015-07-07 14:41:45 UTC
Revisiting this: Einav - wouldn't we want to do something similar to your suggestion on bug 1170259 ?

Comment 5 Einav Cohen 2015-07-20 20:10:16 UTC
(In reply to Allon Mureinik from comment #4)
> Revisiting this: Einav - wouldn't we want to do something similar to your
> suggestion on bug 1170259 ?

[apologies for the late response]

It is possible, but worth understanding the slightly different situation here: 

In my suggestion in bug 1170259 [attachment 994547 [details]], we are denoting a reason for an action that cannot be performed. The user may choose to see the reason (by hovering on the icon) if he'd like, but there is no "danger" here - the action will not be performed in any case. 

In the case detailed here, we want to warn about an action that *can* be performed but may be destructive. In this context, it may be important to explicitly display the warning reason, and not "hide" it behind a tool-tipped icon. Moreover, doing something like attachment 994547 [details] may slightly over-complicate the confirmation ("are you sure") dialog, which should probably be kept relatively simple, mostly text-only, without special interactivity, etc. 

Having said all that - as I mentioned, what you are suggesting is possible. Leaving it to your discretion.

Comment 6 Red Hat Bugzilla Rules Engine 2015-10-20 13:42:35 UTC
Fixed bug tickets must have version flags set prior to fixing them. Please set the correct version flags and move the bugs back to the previous status after this is corrected.

Comment 7 Red Hat Bugzilla Rules Engine 2015-10-20 13:42:35 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 Yaniv Lavi 2015-10-29 12:07:45 UTC
In oVirt testing is done on single stream by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.

Comment 9 Natalie Gavrielov 2015-12-16 11:25:53 UTC
Verified using rhevm-3.6.1.3-0.1.el6.noarch (build 3.6.1-4).
Now, when removing shared disks list is displayed with bullets.

Comment 10 Natalie Gavrielov 2015-12-16 11:29:02 UTC
Created attachment 1106370 [details]
snapshot after the fix

Comment 11 Sandro Bonazzola 2015-12-16 12:23:19 UTC
According to verification status and target milestone this issue should be fixed in oVirt 3.6.1. Closing current release.