RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1139567 - virsh cmd will hang when remove blockcopy file
Summary: virsh cmd will hang when remove blockcopy file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Erik Skultety
QA Contact: Virtualization Bugs
URL:
Whiteboard:
: 1134294 (view as bug list)
Depends On:
Blocks: 1300159
TreeView+ depends on / blocked
 
Reported: 2014-09-09 08:37 UTC by zhe peng
Modified: 2016-01-20 05:07 UTC (History)
7 users (show)

Fixed In Version: libvirt-1.2.8-11.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1300159 (view as bug list)
Environment:
Last Closed: 2015-03-05 07:44:12 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:0323 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2015-03-05 12:10:54 UTC

Description zhe peng 2014-09-09 08:37:03 UTC 
Description of problem:
virsh cmd will hang when remove blockcopy file.

Version-Release number of selected component (if applicable):
host:
libvirt-1.2.8-1.el7.x86_64
qemu-kvm-rhev-2.1.0-3.el7.x86_64
kernel-3.10.0-147.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1.prepare a guest

2.do blockcopy
# virsh blockcopy rhel6 vda /var/lib/libvirt/images/bak --verbose --wait
Block Copy: [100 %]
Now in mirroring phase

3.remove copy file
#rm /var/lib/libvirt/images/bak -f

4.do pivot
# virsh blockjob rhel6 vda --pivot

5.do other block cmd, all will hang.
# virsh blockjob rhel6 vda

6. check xml:
<disk type='file' device='disk'>
      <driver name='qemu' type='qcow2' cache='none'/>
      <source file='/var/lib/libvirt/images/kvm-rhel7.0-x86_64-qcow2v3.img'/>
      <mirror type='file' file='/var/lib/libvirt/images/bak' format='qcow2' job='copy' ready='yes'>
        <format type='qcow2'/>
        <source file='/var/lib/libvirt/images/bak'/>
      </mirror>
      <target dev='vda' bus='virtio'/>
      <alias name='virtio-disk0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/>
    </disk>


Actual results:
virsh will hang up.

Expected results:
better to provide error msg.


Additional info:
Comment 2 Erik Skultety 2014-12-04 08:17:53 UTC 
Fixed upstream:

commit fe3691f66348d55e88c9811fd79ff9314e053977
Author: Erik Skultety <eskultet>
Date:   Wed Dec 3 13:56:47 2014 +0100

    qemu: Fix virsh freeze when blockcopy storage file is removed
    
    If someone removes blockcopy storage file when still in mirroring phase
    and then requesting blockjob abort using pivot, virsh cmd freezes. This
    is not an issue with older qemu versions which did not support
    asynchronous jobs (which we prefer by default).
    As we have reached the mirroring phase successfully, polling monitor for
    blockjob info always returns 1 and the loop never ends.
    This fix introduces a check for qemuDomainBlockPivot return code, possibly
    skipping the asynchronous waiting completely, if an error occurred and
    asynchronous waiting was the preferred method.

v1.2.10-265-gfe3691f
Comment 5 Shanzhi Yu 2014-12-25 03:21:50 UTC 
Verify this bug with libvirt-1.2.8-11.el7.x86_64

Steps:

1. Prepare a transient guest

# virsh list --transient
 Id    Name                           State
----------------------------------------------------
 14    r7                             running

2. Do blockcopy

# virsh blockcopy r7 vda /var/lib/libvirt/images/r7.clone --verbose --wait 
Block Copy: [100 %]
Now in mirroring phase

# virsh dumpxml r7 |grep mirror -A 2 -B 6
    <disk type='network' device='disk'>
      <driver name='qemu' type='raw' cache='none'/>
      <source protocol='gluster' name='gluster-vol1/r7-raw.img'>
        <host name='10.66.5.38'/>
      </source>
      <backingStore/>
      <mirror type='file' file='/var/lib/libvirt/images/r7.clone' format='raw' job='copy' ready='yes'>
        <format type='raw'/>
        <source file='/var/lib/libvirt/images/r7.clone'/>
      </mirror>
      <target dev='vda' bus='virtio'/>


3. Remove the destination file
# rm -fr /var/lib/libvirt/images/r7.clone


4. Do pivot
# virsh blockjob r7 vda --pivot 
error: Cannot access storage file '/var/lib/libvirt/images/r7.clone' (as uid:107, gid:107): No such file or directory

The error is expected, so change to VERIFIED
Comment 6 Eric Blake 2015-01-14 04:59:16 UTC 
*** Bug 1134294 has been marked as a duplicate of this bug. ***
Comment 7 Eric Blake 2015-01-14 05:02:23 UTC 
The hang occurred not just from removing a backing file, but also from the much more likely attempt to attempt a virDomainBlockJobAbort operation with the pivot flag prior to an active commit completing (see the reproduction example in bug 1134294)
Comment 9 errata-xmlrpc 2015-03-05 07:44:12 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html
Note You need to log in before you can comment on or make changes to this bug.