Bug 1139820 - Improve EAP Patch Deploy Failure Message
Summary: Improve EAP Patch Deploy Failure Message
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Operations Network
Classification: JBoss
Component: Plugin -- Other
Version: JON 3.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ER05
: JON 3.3.0
Assignee: Michael Burman
QA Contact: Mike Foley
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-09 17:31 UTC by Matt Mahoney
Modified: 2014-12-11 13:59 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2014-12-11 13:59:49 UTC


Attachments (Terms of Use)

Description Matt Mahoney 2014-09-09 17:31:23 UTC
Description of problem:
EAP Patch Deploy failure messages could be more user friendly / easier to read.

In this example, the even elimination of the "java.lang..." text would make the failure message easier to read:

Failed to schedule deployment: java.lang.RuntimeException:[1410283498846] javax.ejb.EJBException:java.lang.IllegalArgumentException: Destination [BundleDestination[id=10042, bundle=EAP, group=EAP-Standalone-2, name=ServerBase6.2.0]] group has no members. Invalid deployment destination -> java.lang.IllegalArgumentException:Destination [BundleDestination[id=10042, bundle=EAP, group=EAP-Standalone-2, name=ServerBase6.2.0]] group has no members. Invalid deployment destination


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Deploy an EAP patch that purposely fails. Note the failure message.
2.
3.

Actual results:


Expected results:
Make the deploy EAP patch deploy failure message easier for the user to read.

Additional info:

Comment 2 Simeon Pinder 2014-09-29 08:12:52 UTC
Moving into ER05 as didn't make the ER04 cut.

Comment 3 Michael Burman 2014-10-03 13:51:16 UTC
I talked about the issue with the rest of the team on our call, and there's a reason to keep those exceptionClassnames there (it is easier to assist the customer). Cleaning up all of them would require some changes to every error message we currently do, so I only removed the first "RuntimeException", as it provides no extra value to us.

In master:

commit 6ad2b57830862470b22afc52c7ab34d3c3226752
Author: Michael Burman <miburman@redhat.com>
Date:   Fri Oct 3 16:49:16 2014 +0300

    [BZ 1139820] Remove one useless exception className from the error message from all Bundle related exceptions

Comment 4 Libor Zoubek 2014-10-08 09:51:20 UTC
branch:  release/jon3.3.x
link:    https://github.com/rhq-project/rhq/commit/719d7a7af
time:    2014-10-08 11:50:25 +0200
commit:  719d7a7afe8e6b5c9119c5e18c55dbe164e5f9a8
author:  Michael Burman - miburman@redhat.com
message: [BZ 1139820] Remove one useless exception className from the error
         message from all Bundle related exceptions
         (cherry picked from commit
         6ad2b57830862470b22afc52c7ab34d3c3226752) Signed-off-by: Libor
         Zoubek <lzoubek@redhat.com>

Comment 6 Simeon Pinder 2014-10-21 20:24:30 UTC
Moving to ON_QA as available to test with the latest brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=394734


Note You need to log in before you can comment on or make changes to this bug.