REVIEW: http://review.gluster.org/8672 (dht: fix rename race) posted (#1) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8675 (storage/posix: removing deleting entries in case of creation failures) posted (#1) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8676 (dht: fix rename race) posted (#1) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8676 (dht: fix rename race) posted (#2) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8675 (storage/posix: removing deleting entries in case of creation failures) posted (#2) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8672 (dht: fix rename race) posted (#2) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8676 (dht: fix rename race) posted (#3) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8675 (storage/posix: removing deleting entries in case of creation failures) posted (#3) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8672 (dht: fix rename race) posted (#3) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8676 (dht: fix rename race) posted (#4) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8675 (storage/posix: removing deleting entries in case of creation failures) posted (#4) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8672 (dht: fix rename race) posted (#4) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8676 (dht: fix rename race) posted (#5) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8675 (storage/posix: removing deleting entries in case of creation failures) posted (#5) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8672 (dht: fix rename race) posted (#5) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8676 (dht: fix rename race) posted (#6) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8675 (storage/posix: removing deleting entries in case of creation failures) posted (#6) for review on release-3.4 by Raghavendra G (rgowdapp)

REVIEW: http://review.gluster.org/8672 (dht: fix rename race) posted (#6) for review on release-3.4 by Raghavendra G (rgowdapp)

COMMIT: http://review.gluster.org/8672 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) 
------
commit a7356806f9f7c148d4e0a972f6a418d1ca82bcd0
Author: Jeff Darcy <jdarcy>
Date:   Tue Jul 8 21:56:04 2014 -0400

    dht: fix rename race
    
    If two clients try to rename the same file at the same time, we
    sometimes end up with *no file at all* in either the old or new
    location.  That's kind of bad.  The culprit seems to be some overly
    aggressive cleanup code.  AFAICT, based on today's study of the code,
    the intent of the changed section is to remove any linkfile we might
    have created before the actual rename.  However, what we're removing
    might not be our extra link.  If we're racing with another client that's
    also doing a rename, it might be the only remaining link to the user's
    data.  The solution, which is good enough to pass this test but almost
    certainly still not complete, is to be more selective about when we do
    this unlink.  Now, we only do it if we know that, at some point, we did
    in fact create the link without error (notably ENOENT on the source or
    EEXIST on the destination) ourselves.
    
    Change-Id: I8d8cce150b6f8b372c9fb813c90be58d69f8eb7b
    BUG: 1139988
    Signed-off-by: Jeff Darcy <jdarcy>
    Reviewed-on: http://review.gluster.org/8269
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/8672
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

COMMIT: http://review.gluster.org/8675 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) 
------
commit fe5cf303121215be6f00b4da0796fbf83922ec36
Author: Raghavendra G <rgowdapp>
Date:   Fri Sep 5 12:05:15 2014 +0530

    storage/posix: removing deleting entries in case of creation failures
    
    The code is not atomic enough to not to delete a dentry created by a
    prallel dentry creation operation.
    
    Change-Id: I9bd6d2aa9e7a1c0688c0a937b02a4b4f56d7aa3d
    BUG: 1139988
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/8327
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/8675
    Reviewed-by: Kaleb KEITHLEY <kkeithle>

COMMIT: http://review.gluster.org/8676 committed in release-3.4 by Kaleb KEITHLEY (kkeithle) 
------
commit ebdb73daa1c4553b263b208afd22a299e6b7b233
Author: Nithya Balachandran <nbalacha>
Date:   Mon Jul 21 18:46:14 2014 +0530

    dht: fix rename race
    
    Additional check to check if we created the linkto
    file before deleting it in the rename cleanup function
    
    Change-Id: I919cd7cb24f948ba4917eb9cf50d5169bb730a67
    BUG: 1139988
    Signed-off-by: Nithya Balachandran <nbalacha>
    Reviewed-on: http://review.gluster.org/8338
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/8676
    Reviewed-by: Kaleb KEITHLEY <kkeithle>