Bug 1140378 - Domain env variables not cleaned up if app create fails/canceled
Summary: Domain env variables not cleaned up if app create fails/canceled
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 2.1.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: ---
Assignee: Luke Meyer
QA Contact: libra bugs
URL:
Whiteboard:
: 1131011 (view as bug list)
Depends On: 1140265
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-10 19:55 UTC by Brenton Leanhardt
Modified: 2014-10-02 13:59 UTC (History)
8 users (show)

Fixed In Version: rubygem-openshift-origin-controller-1.23.10.14-1.el6op
Doc Type: Bug Fix
Doc Text:
Previously, domain environment variables were not removed after an application failed during creation or if the operation was canceled by the user. As a result, attempting to later create an application with the same name would fail because MongoDB records still existed for the failed application. This bug fix updates the pending operations logic to remove domain environment variables and SSH keys for an application if the creation fails or is canceled.
Clone Of: 1140265
Environment:
Last Closed: 2014-10-02 13:59:53 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2014:1353 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.1.7 bug fix and enhancement update 2014-10-02 17:59:00 UTC

Description Brenton Leanhardt 2014-09-10 19:55:27 UTC 
+++ This bug was initially created as a clone of Bug #1140265 +++

Description of problem:
See JIRA: https://issues.jboss.org/browse/ENTESB-1926

--- Additional comment from Abhishek Gupta on 2014-09-10 15:52:35 EDT ---

This was a similar bug that got fixed --> https://bugzilla.redhat.com/show_bug.cgi?id=1126826

Corresponding PR --> https://github.com/openshift/origin-server/pull/5717
Comment 3 Luke Meyer 2014-09-22 16:44:33 UTC 
*** Bug 1131011 has been marked as a duplicate of this bug. ***
Comment 4 Luke Meyer 2014-09-22 16:51:55 UTC 
Cherry-picking:
commit 9e02f63c0044b3c76eb77c492672c08ac3436196
Author: Abhishek Gupta <abhgupta>
Date:   Fri Aug 15 16:38:07 2014 -0700

    Bug 1126826: cleaning up domain env vars and ssh keys on rollback
Comment 9 xjia 2014-09-23 06:06:52 UTC 
Version: 2.1.z/2014-09-22.2/
Verify:
1. Create a fuse application. Check mongodb:
"env_vars" : [
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_DNS",
			"value" : "fuse-jia.fuse-vsphere.com",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		},
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_SSH_PORT",
			"value" : "43827",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		},
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_ZOOKEEPER_URL",
			"value" : "fuse-jia.fuse-vsphere.com:43826",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		},
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_PASSWORD",
			"value" : "D-geyXLppXaJ",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		}
	],
2. From Hawtio, create 20 containers at the same time.At the end, most of them are created failed. 
3. Check mongodb, env_vars valude is not changed.
	"env_vars" : [
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_DNS",
			"value" : "fuse-jia.fuse-vsphere.com",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		},
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_SSH_PORT",
			"value" : "43827",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		},
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_ZOOKEEPER_URL",
			"value" : "fuse-jia.fuse-vsphere.com:43826",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		},
		{
			"key" : "OPENSHIFT_FUSE_DOMAIN_PASSWORD",
			"value" : "D-geyXLppXaJ",
			"component_id" : ObjectId("5420eb8e1018d6c3ca000054"),
			"unique" : false
		}
	],
Comment 11 errata-xmlrpc 2014-10-02 13:59:53 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1353.html
Note You need to log in before you can comment on or make changes to this bug.