Bug 1140613 - [AFR-V2] - SHD doesn't remember selfheal failures before updating pending entry heal count
Summary: [AFR-V2] - SHD doesn't remember selfheal failures before updating pending ent...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: replicate
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Krutika Dhananjay
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-11 10:47 UTC by Krutika Dhananjay
Modified: 2015-05-14 17:43 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.7.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-05-14 17:27:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Krutika Dhananjay 2014-09-11 10:47:42 UTC
Description of problem:

While reading code, I figured that in entry selfheal, SHD doesn't remember the failure to heal entries (if any). This would cause it to unconditionally reset pending entry selfheal count in postop even when there have been heal failures in healed_sinks[].

Version-Release number of selected component (if applicable):
AFR-V2

How reproducible:
N/A

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-09-22 11:33:38 UTC
REVIEW: http://review.gluster.org/8808 (cluster/afr: Do not reset pending xattrs on gfid mismatch in entry-sh) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Anand Avati 2014-09-23 08:32:55 UTC
REVIEW: http://review.gluster.org/8816 (cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Anand Avati 2014-09-23 09:02:42 UTC
REVIEW: http://review.gluster.org/8816 (cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Anand Avati 2014-09-23 09:12:14 UTC
REVIEW: http://review.gluster.org/8816 (cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 5 Anand Avati 2014-09-23 14:25:16 UTC
COMMIT: http://review.gluster.org/8816 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 125e5428d31f5e0b659cbdb9ccdc310991fc1981
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Sep 18 18:26:08 2014 +0530

    cluster/afr: Do not reset pending xattrs on gfid or type mismatch in entry-sh
    
    Change-Id: Ie27219a376382e2455a0fcc094f8b7eb243738ae
    BUG: 1140613
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/8816
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Pranith Kumar Karampuri <pkarampu>

Comment 6 Niels de Vos 2015-05-14 17:27:39 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:35:36 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:37:57 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:43:42 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.