Spec URL: http://petersen.fedorapeople.org/reviews/ghc-conduit-extra.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-conduit-extra-1.0.0.1-2.fc20.src.rpm Description: The conduit package itself maintains relative small dependencies. The purpose of this package is to collect commonly used utility functions wrapping other library dependencies, without depending on heavier-weight dependencies. The basic idea is that this package should only depend on haskell-platform packages and conduit.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7570271
1.0 is a dummy placeholder package before conduit-extra-1.1. Plan to move to 1.1 together with conduit-1.1. The package will later replace *-conduit.
http://packdeps.haskellers.com/reverse/conduit-extra
LGTM (should take another look once 1.1 is used though) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/boeckb/misc/code/review/1140914-ghc-conduit-extra/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. 1.0.0.1 is the latest 1.0 release (1.1 to follow). [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-conduit-extra-1.0.0.1-2.fc22.x86_64.rpm ghc-conduit-extra-devel-1.0.0.1-2.fc22.x86_64.rpm ghc-conduit-extra-1.0.0.1-2.fc22.src.rpm ghc-conduit-extra.x86_64: W: spelling-error %description -l en_US haskell -> Haskell ghc-conduit-extra.x86_64: E: no-binary ghc-conduit-extra-devel.x86_64: W: only-non-binary-in-usr-lib ghc-conduit-extra-devel.x86_64: W: no-documentation ghc-conduit-extra.src: W: spelling-error %description -l en_US haskell -> Haskell 3 packages and 0 specfiles checked; 1 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- ghc-conduit-extra (rpmlib, GLIBC filtered): ghc-conduit-extra-devel (rpmlib, GLIBC filtered): /bin/sh ghc-compiler ghc-conduit-extra(x86-64) Provides -------- ghc-conduit-extra: ghc-conduit-extra ghc-conduit-extra(x86-64) ghc-conduit-extra-devel: ghc-conduit-extra-devel ghc-conduit-extra-devel(x86-64) ghc-conduit-extra-static Source checksums ---------------- http://hackage.haskell.org/package/conduit-extra-1.0.0.1/conduit-extra-1.0.0.1.tar.gz : CHECKSUM(SHA256) this package : ea5d045ea103f85993caf1b04faf615f75b822cce9c06130ac9190863a235547 CHECKSUM(SHA256) upstream package : ea5d045ea103f85993caf1b04faf615f75b822cce9c06130ac9190863a235547 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64-bb-tmpfs --bug 1140914 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Haskell, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thank you for the review. New Package SCM Request ======================= Package Name: ghc-conduit-extra Short Description: Conduit adapters for common libraries Upstream URL: http://hackage.haskell.org/package/conduit-extra Owners: petersen Branches: f21 f20 epel7 InitialCC: haskell-sig
Git done (by process-git-requests).
Okay I will leave this open until the package is updated to 1.1 as a reminder to check over the updated packaging. :)
ghc-conduit-extra-1.0.0.1-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ghc-conduit-extra-1.0.0.1-2.fc21
ghc-conduit-extra-1.0.0.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-conduit-extra-1.0.0.1-2.fc20
ghc-conduit-extra-1.0.0.1-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-conduit-extra-1.0.0.1-2.el7
ghc-conduit-extra-1.0.0.1-2.fc21 has been pushed to the Fedora 21 stable repository.
ghc-conduit-extra-1.0.0.1-2.fc20 has been pushed to the Fedora 20 stable repository.
ghc-conduit-extra-1.0.0.1-2.el7 has been pushed to the Fedora EPEL 7 stable repository.
Okay I just pushed conduit-extra-1.1 to pkg git master earlier, if want to have a look and check things look in order? :) http://pkgs.fedoraproject.org/cgit/ghc-conduit-extra.git/commit/?id=ead8e868e40734791d62a2431d765c7e4f24c7ff
Actually: http://pkgs.fedoraproject.org/cgit/ghc-conduit-extra.git/tree/?id=63c4f611c445789a32aad9b74eee55e9b6da05c2
Ben, any objections to closing this?