Bug 1141267
| Summary: | do not silently ignore failure to read ifcfg files | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | Dan Kenigsberg <danken> |
| Component: | General | Assignee: | Leon Goldberg <lgoldber> |
| Status: | CLOSED WONTFIX | QA Contact: | Lukas Svaty <lsvaty> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | --- | CC: | bazulay, bugs, mgoldboi, rbalakri, sbonazzo, srevivo, ykaul, ylavi |
| Target Milestone: | --- | Flags: | sbonazzo:
ovirt-4.1-
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-20 06:06:55 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Network | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
We are too afraid to truly fix this, since it would make it impossible to acquire non-vdsm ifcfg files if they are malformed for whatever reason. In good days, I'd say - let it fail and fix the out-of-ovirt thing that made them malformed. But this is not a good day, so we'd just swallow the exception, but log it. |
swallowing all exceptions in def getIfaceCfg(iface): ifaceCfg = {} try: with open(NET_CONF_PREF + iface) as f: for line in shlex.split(f, comments=True): k, v = line.split('=', 1) if k in _IFCFG_ZERO_SUFFIXED: k = k[:-1] ifaceCfg[k] = v except Exception: pass return ifaceCfg is evil and caused bug 1139687