Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1141359

Summary: The tabs in the Launch Instance dialog look disabled (light grey)
Product: Red Hat OpenStack Reporter: Jeff Needle <jneedle>
Component: python-django-horizonAssignee: Angus Thomas <athomas>
Status: CLOSED CURRENTRELEASE QA Contact: Ido Ovadia <iovadia>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 5.0 (RHEL 6)CC: aortega, athomas, jneedle, mreid, mrunge, sclark, yeylon
Target Milestone: ---Keywords: Triaged, ZStream
Target Release: 5.0 (RHEL 7)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-15 12:06:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Launch Instance tabs
none
Disabled buttons in Horizon
none
Buttons in 6.0
none
All tab text using the active coloring
none
Launch Instance tabs - RDO Juno none

Description Jeff Needle 2014-09-12 19:03:43 UTC
The tabs in the Launch Instance dialog look disabled (light grey)

Comment 2 Julie Pichon 2014-09-17 05:21:51 UTC
Could you provide a screenshot, information on the browser you're using and the horizon package version? I assume you're using the Red Hat RCUE theme but even then I seem unable to reproduce the bug using either Firefox or Chrome.

Comment 3 Julie Pichon 2014-09-17 05:22:27 UTC
Created attachment 938334 [details]
Launch Instance tabs

Comment 4 Matt Reid 2014-09-23 15:58:19 UTC
Created attachment 940492 [details]
Disabled buttons in Horizon

To me, the non-selected tabs and the disabled buttons seen throughout Horizon look to be similarly desaturated.

Comment 5 Julie Pichon 2014-09-25 07:02:34 UTC
I'm sorry Matt, I'm not sure if I understand your comment correctly. Are you saying the tabs are consistent with the rest of Horizon? Otherwise, I'm having difficulties telling whether you're saying the current state is good or bad, how it relates to the tabs or what is the expected solution. Could you provide a bit more details? (A simplified version for dummies is ok too :-))

To me the enabled buttons look like they have some "relief" and can be pushed while the disabled ones don't, but I've got a feeling I'm missing the point of the comment.

Note that the button design will change in 6.0. I'll attach a screenshot. I don't think there's any change to the tab design/colours though.

Comment 6 Julie Pichon 2014-09-25 07:03:33 UTC
Created attachment 940984 [details]
Buttons in 6.0

Comment 7 Matt Reid 2014-09-29 15:37:11 UTC
Sorry Julie, the current state is not ideal, hence the bug report :) 

GIMP says that we use the web color "555555" for the active tab title, and then switch to "9bb5bf" for the non-active tabs. These colors look very different, and that light blue/gray actually more closely resembles colors used for disabled elements. Usually with tabs, you'll either see consistent coloring across all tabs, or the active tab will be brighter/bolder than the others. The current implementation is opposite of what is used in PatternFly, as Horizon uses a normal color for the active tab, and then weaker colors for all of the other tabs, rather than a normal color for the inactive tabs and a stronger color for the active tab. You can see an example of tabs in PatternFly here: https://www.patternfly.org/wp-content/uploads/patternfly/tests/tab.html

The lack of contrast in the current coloring of those tabs is more similar to the disabled buttons I included in a previous screenshot, rather than other active elements in the UI.

Either moving to using a consistent color across all tabs, or more closely matching the PatternFly recommendations would make for nicer, more legible tabs.

Comment 8 Matt Reid 2014-09-29 15:39:10 UTC
Created attachment 942384 [details]
All tab text using the active coloring

Here's a quick example of what it would look like if we changed the inactive tab titles to use the same color as the active tab. I think it makes it much more readable, and no longer looks like that tab might be disabled.

Comment 9 Julie Pichon 2014-11-19 10:36:24 UTC
Created attachment 958932 [details]
Launch Instance tabs - RDO Juno

I believe this is resolved in Juno (OSP 6.0) with the redesign that took place there, the blue is stronger.

Comment 12 Matthias Runge 2015-12-15 12:06:39 UTC
This bug was closed as part of a backlog clean up.
If you see value in tracking this bug please re-open it.