Bug 1141389 - Review Request: perl-DBIx-Connector - Fast, safe DBI connection and transaction management
Summary: Review Request: perl-DBIx-Connector - Fast, safe DBI connection and transact...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Dick
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-09-13 00:07 UTC by Denis Fateyev
Modified: 2014-10-09 19:56 UTC (History)
3 users (show)

Fixed In Version: perl-DBIx-Connector-0.53-2.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-23 04:40:05 UTC
Type: ---
Embargoed:
ddick: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Denis Fateyev 2014-09-13 00:07:26 UTC
Spec URL: http://www.fateyev.com/RPMS/Fedora20/testing/perl-DBIx-Connector.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-DBIx-Connector-0.53-1.fc20.denf.src.rpm
Description: DBIx::Connector provides a simple interface for fast and safe DBI connection and transaction management. It allows to keep a database handle to maintain a connection in order to minimize overhead without having to worry about dropped or corrupted connections.

Borrowing an interface from DBIx::Class, DBIx::Connector also offers an API that handles the scoping of database transactions. In addition, it offers an API for savepoints if a database supports them.
Fedora Account System Username: dfateyev

Koji scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7574095 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7573985 (EPEL 7)

Comment 1 David Dick 2014-09-14 10:21:00 UTC
Licensing is correct.

Builds successfully in rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7575705

rpmlint warnings may be ignored.

The "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;" line may be removed.  This should be handled by "create_packlist=0"

Add the following BRs

BuildRequire: perl(base)
BuildRequire: perl(Carp)
BuildRequire: perl(Cwd)
BuildRequire: perl(File::Basename)
BuildRequire: perl(File::Spec)

Add the following RunTime requires

Require: perl(Carp)

Comment 2 David Dick 2014-09-14 11:05:50 UTC
Scratch the following BRs

BuildRequire: perl(Cwd)
BuildRequire: perl(File::Basename)
BuildRequire: perl(File::Spec)

These are not required.

Comment 4 David Dick 2014-09-14 20:56:06 UTC
Builds successfully at http://koji.fedoraproject.org/koji/taskinfo?taskID=7576666

Build and RunTime requires look good.

Package APPROVED

Comment 5 Denis Fateyev 2014-09-14 22:19:53 UTC
New Package SCM Request
=======================
Package Name: perl-DBIx-Connector
Short Description: Fast, safe DBI connection and transaction management
Owners: dfateyev
Branches: f19 f20 f21 epel7
InitialCC: perl-sig

Comment 6 Gwyn Ciesla 2014-09-15 12:23:30 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-09-16 19:48:40 UTC
perl-DBIx-Connector-0.53-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/perl-DBIx-Connector-0.53-2.el7

Comment 8 Fedora Update System 2014-09-16 19:50:54 UTC
perl-DBIx-Connector-0.53-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-DBIx-Connector-0.53-2.fc21

Comment 9 Fedora Update System 2014-09-16 19:52:27 UTC
perl-DBIx-Connector-0.53-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-DBIx-Connector-0.53-2.fc20

Comment 10 Fedora Update System 2014-09-16 19:54:28 UTC
perl-DBIx-Connector-0.53-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-DBIx-Connector-0.53-2.fc19

Comment 11 Fedora Update System 2014-09-18 16:12:20 UTC
perl-DBIx-Connector-0.53-2.fc21 has been pushed to the Fedora 21 testing repository.

Comment 12 Fedora Update System 2014-09-23 04:40:05 UTC
perl-DBIx-Connector-0.53-2.fc21 has been pushed to the Fedora 21 stable repository.

Comment 13 Fedora Update System 2014-09-27 09:48:30 UTC
perl-DBIx-Connector-0.53-2.fc19 has been pushed to the Fedora 19 stable repository.

Comment 14 Fedora Update System 2014-09-27 09:50:26 UTC
perl-DBIx-Connector-0.53-2.fc20 has been pushed to the Fedora 20 stable repository.

Comment 15 Fedora Update System 2014-10-09 19:56:02 UTC
perl-DBIx-Connector-0.53-2.el7 has been pushed to the Fedora EPEL 7 stable repository.


Note You need to log in before you can comment on or make changes to this bug.